Re: [PATCH 1/3] rhashtable: Remove GFP flag from rhashtable_walk_init

2016-08-19 Thread Herbert Xu
On Fri, Aug 19, 2016 at 06:25:04PM +0200, Thomas Graf wrote: > On 08/18/16 at 04:50pm, Herbert Xu wrote: > > +/* Obsolete function, do not use in new code. */ > > +static inline int rhashtable_walk_init(struct rhashtable *ht, > > + struct rhashtable_iter *iter, gfp_

Re: [PATCH 1/3] rhashtable: Remove GFP flag from rhashtable_walk_init

2016-08-19 Thread Thomas Graf
On 08/18/16 at 04:50pm, Herbert Xu wrote: > +/* Obsolete function, do not use in new code. */ > +static inline int rhashtable_walk_init(struct rhashtable *ht, > +struct rhashtable_iter *iter, gfp_t gfp) > +{ > + rhashtable_walk_enter(ht, iter); > + return

[PATCH 1/3] rhashtable: Remove GFP flag from rhashtable_walk_init

2016-08-18 Thread Herbert Xu
The commit 8f6fd83c6c5ec66a4a70c728535ddcdfef4f3697 ("rhashtable: accept GFP flags in rhashtable_walk_init") added a GFP flag argument to rhashtable_walk_init because some users wish to use the walker in an unsleepable context. In fact we don't need to allocate memory in rhashtable_walk_init at al