>> What do you think?
>
> Passing -1 is an error, it doesn't make sense to try and be
> helpful to buggy userland.
Here is commit I actually change/fix:
commit 9c7dafbfab15 ("net: Allow to create links with given ifindex")
In this change done the opposite: check for ifm->ifi_index moved to
regi
On Fri, 16 Jun 2017 19:44:45 +0300
Serhey Popovych wrote:
> > On Fri, 16 Jun 2017 17:23:51 +0300
> > Serhey Popovych wrote:
> >
> >> Interface index is signed integer, we can pass ifm->ifi_index
> >> from userspace via netlink and create network device with
> >> negative ifindex value.
> >>
>
> On Fri, 16 Jun 2017 17:23:51 +0300
> Serhey Popovych wrote:
>
>> Interface index is signed integer, we can pass ifm->ifi_index
>> from userspace via netlink and create network device with
>> negative ifindex value.
>>
>> Fixes: 9c7dafbfab15 ("net: Allow to create links with given ifindex")
>>
On Fri, 16 Jun 2017 17:23:51 +0300
Serhey Popovych wrote:
> Interface index is signed integer, we can pass ifm->ifi_index
> from userspace via netlink and create network device with
> negative ifindex value.
>
> Fixes: 9c7dafbfab15 ("net: Allow to create links with given ifindex")
> Signed-off-b
Interface index is signed integer, we can pass ifm->ifi_index
from userspace via netlink and create network device with
negative ifindex value.
Fixes: 9c7dafbfab15 ("net: Allow to create links with given ifindex")
Signed-off-by: Serhey Popovych
---
net/core/dev.c | 2 +-
1 file changed, 1 insert
