Re: [PATCH 1/2] net: phy: leds: Clear phy_num_led_triggers on failure to avoid crash

2017-01-24 Thread Florian Fainelli
On 01/24/2017 07:41 AM, Geert Uytterhoeven wrote: > phy_attach_direct() ignores errors returned by > phy_led_triggers_register(). I think that's OK, as LED triggers can be > considered a non-critical feature. > > However, this causes problems later: > - phy_led_trigger_change_speed() will access

[PATCH 1/2] net: phy: leds: Clear phy_num_led_triggers on failure to avoid crash

2017-01-24 Thread Geert Uytterhoeven
phy_attach_direct() ignores errors returned by phy_led_triggers_register(). I think that's OK, as LED triggers can be considered a non-critical feature. However, this causes problems later: - phy_led_trigger_change_speed() will access the array phy_device.phy_led_triggers, which has been fre