Re: [PATCH 1/2] net: phy: improve phylib correctness for non-autoneg settings

2017-04-17 Thread David Miller
From: Russell King Date: Thu, 13 Apr 2017 16:49:15 +0100 > phylib has some undesirable behaviour when forcing a link mode through > ethtool. phylib uses this code: > > idx = phy_find_valid(phy_find_setting(phydev->speed, phydev->duplex), > features); > > to find an

[PATCH 1/2] net: phy: improve phylib correctness for non-autoneg settings

2017-04-13 Thread Russell King
phylib has some undesirable behaviour when forcing a link mode through ethtool. phylib uses this code: idx = phy_find_valid(phy_find_setting(phydev->speed, phydev->duplex), features); to find an index in the settings table. phy_find_setting() starts at index 0, a