Re: [PATCH 1/2] NetXen: Added ethtool support for user level tools

2007-01-31 Thread Amit Kale
Ueimor, Jeff, Thanks for reviewing. We are integrating these into our code and will send an update tomorrow. -Amit On Wednesday 31 January 2007 15:46, Jeff Garzik wrote: > Amit S. Kale wrote: > > Added ethtool support for user level firmware management utilities. > > > > Signed-off-by: Amit S.

Re: [PATCH 1/2] NetXen: Added ethtool support for user level tools

2007-01-31 Thread Jeff Garzik
Amit S. Kale wrote: Added ethtool support for user level firmware management utilities. Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> You will need to resend against netdev#upstream, which now contains Al Viro's netxen annotations. Please add sparse checking (read Documentation/sparse.txt

Re: [PATCH 1/2] NetXen: Added ethtool support for user level tools

2007-01-30 Thread Francois Romieu
Amit S. Kale <[EMAIL PROTECTED]> : [...] > diff --git a/drivers/net/netxen/netxen_nic_ethtool.c > b/drivers/net/netxen/netxen_nic_ethtool.c > index 3404461..49b3b4c 100644 > --- a/drivers/net/netxen/netxen_nic_ethtool.c > +++ b/drivers/net/netxen/netxen_nic_ethtool.c [...] > static void > @@ -445

[PATCH 1/2] NetXen: Added ethtool support for user level tools

2007-01-30 Thread Amit S. Kale
Added ethtool support for user level firmware management utilities. Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> --- netxen_nic.h | 16 ++- netxen_nic_ethtool.c | 87 +--- netxen_nic_init.c| 268 ++- 3 files changed