Re: [PATCH 1/1] vsock: fix the race conditions in multi-transport support

2021-02-01 Thread Alexander Popov
On 01.02.2021 11:26, Stefano Garzarella wrote: > On Sun, Jan 31, 2021 at 01:59:14PM +0300, Alexander Popov wrote: >> There are multiple similar bugs implicitly introduced by the >> commit c0cfa2d8a788fcf4 ("vsock: add multi-transports support") and >> commit 6a2c0962105ae8ce ("vsock: prevent transp

Re: [PATCH 1/1] vsock: fix the race conditions in multi-transport support

2021-02-01 Thread Stefano Garzarella
On Sun, Jan 31, 2021 at 01:59:14PM +0300, Alexander Popov wrote: There are multiple similar bugs implicitly introduced by the commit c0cfa2d8a788fcf4 ("vsock: add multi-transports support") and commit 6a2c0962105ae8ce ("vsock: prevent transport modules unloading"). The bug pattern: [1] vsock_soc

Re: [PATCH 1/1] vsock: fix the race conditions in multi-transport support

2021-01-31 Thread Linus Torvalds
[ I'm checking lkml for at least some of the emails that I'm cc'd on ] On Sun, Jan 31, 2021 at 2:59 AM Alexander Popov wrote: > > There are multiple similar bugs implicitly introduced by the > commit [...] Note: this got eaten or delayed by the mailing list issues that seem to be plaguing lkml -

[PATCH 1/1] vsock: fix the race conditions in multi-transport support

2021-01-31 Thread Alexander Popov
There are multiple similar bugs implicitly introduced by the commit c0cfa2d8a788fcf4 ("vsock: add multi-transports support") and commit 6a2c0962105ae8ce ("vsock: prevent transport modules unloading"). The bug pattern: [1] vsock_sock.transport pointer is copied to a local variable, [2] lock_sock(