On Sun, 13 Dec 2020 11:48:15 +0200 Yonatan Linik wrote:
> > You're right, on a closer look most of the places have a larger #ifdef
> > block (which my grep didn't catch) or are under Kconfig. Of those I
> > checked only TLS looks wrong (good job me) - would you care to fix that
> > one as well, or
On Sat, Dec 12, 2020 at 11:51 PM Jakub Kicinski wrote:
>
> On Sat, 12 Dec 2020 23:39:20 +0200 Yonatan Linik wrote:
> > On Sat, Dec 12, 2020 at 9:48 PM Jakub Kicinski wrote:
> > >
> > > On Fri, 11 Dec 2020 18:37:49 +0200 Yonatan Linik wrote:
> > > > proc_fs was used, in af_packet, without a surrou
On Sat, 12 Dec 2020 23:39:20 +0200 Yonatan Linik wrote:
> On Sat, Dec 12, 2020 at 9:48 PM Jakub Kicinski wrote:
> >
> > On Fri, 11 Dec 2020 18:37:49 +0200 Yonatan Linik wrote:
> > > proc_fs was used, in af_packet, without a surrounding #ifdef,
> > > although there is no hard dependency on proc_f
On Sat, Dec 12, 2020 at 9:48 PM Jakub Kicinski wrote:
>
> On Fri, 11 Dec 2020 18:37:49 +0200 Yonatan Linik wrote:
> > proc_fs was used, in af_packet, without a surrounding #ifdef,
> > although there is no hard dependency on proc_fs.
> > That caused the initialization of the af_packet module to fai
On Fri, 11 Dec 2020 18:37:49 +0200 Yonatan Linik wrote:
> proc_fs was used, in af_packet, without a surrounding #ifdef,
> although there is no hard dependency on proc_fs.
> That caused the initialization of the af_packet module to fail
> when CONFIG_PROC_FS=n.
>
> Specifically, proc_create_net() w
On Fri, Dec 11, 2020 at 11:00 PM Arnd Bergmann wrote:
>
> Another option would be to just ignore the return code here
> and continue without a procfs file, regardless of whether procfs
> is enabled or not.
>
>Arnd
Yes I thought about that, but I didn't want to make changes to the way
it b
On Fri, Dec 11, 2020 at 5:37 PM Yonatan Linik wrote:
> index 2b33e977a905..031f2b593720 100644
> --- a/net/packet/af_packet.c
> +++ b/net/packet/af_packet.c
> @@ -4612,9 +4612,11 @@ static int __net_init packet_net_init(struct net *net)
> mutex_init(&net->packet.sklist_lock);
> IN
proc_fs was used, in af_packet, without a surrounding #ifdef,
although there is no hard dependency on proc_fs.
That caused the initialization of the af_packet module to fail
when CONFIG_PROC_FS=n.
Specifically, proc_create_net() was used in af_packet.c,
and when it fails, packet_net_init() returns
