Re: [Devel] [PATCH 1/1] Dynamically allocate the loopback device

2007-08-27 Thread Eric W. Biederman
Stephen Hemminger <[EMAIL PROTECTED]> writes: > On Fri, 24 Aug 2007 19:55:47 +0400 > "Denis V. Lunev" <[EMAIL PROTECTED]> wrote: > >> [EMAIL PROTECTED] wrote: >> > From: Daniel Lezcano <[EMAIL PROTECTED]> >> > >> > Doing this makes loopback.c a better example of how to do a >> > simple network de

Re: [Devel] [PATCH 1/1] Dynamically allocate the loopback device

2007-08-24 Thread Denis V. Lunev
no, and this is important. Loopback is initialized in fs_initcall which is called sufficiently before module_init. I have checked the code and do not see initialization order mistakes right now. But, from now on, maintainer should pay attention for this unfortunate consequence :( Regards, Den

Re: [Devel] [PATCH 1/1] Dynamically allocate the loopback device

2007-08-24 Thread Stephen Hemminger
On Fri, 24 Aug 2007 19:55:47 +0400 "Denis V. Lunev" <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] wrote: > > From: Daniel Lezcano <[EMAIL PROTECTED]> > > > > Doing this makes loopback.c a better example of how to do a > > simple network device, and it removes the special case > > single static a

Re: [Devel] [PATCH 1/1] Dynamically allocate the loopback device

2007-08-24 Thread Daniel Lezcano
Denis V. Lunev wrote: [EMAIL PROTECTED] wrote: From: Daniel Lezcano <[EMAIL PROTECTED]> Doing this makes loopback.c a better example of how to do a simple network device, and it removes the special case single static allocation of a struct net_device, hopefully making maintenance easier. Appli

Re: [Devel] [PATCH 1/1] Dynamically allocate the loopback device

2007-08-24 Thread Denis V. Lunev
[EMAIL PROTECTED] wrote: > From: Daniel Lezcano <[EMAIL PROTECTED]> > > Doing this makes loopback.c a better example of how to do a > simple network device, and it removes the special case > single static allocation of a struct net_device, hopefully > making maintenance easier. > > Applies agains

[PATCH 1/1] Dynamically allocate the loopback device

2007-08-24 Thread dlezcano
From: Daniel Lezcano <[EMAIL PROTECTED]> Doing this makes loopback.c a better example of how to do a simple network device, and it removes the special case single static allocation of a struct net_device, hopefully making maintenance easier. Applies against net-2.6.24 Tested on i386, x86_64 Comp