Re: [PATCH 09/10] treewide: Remove uninitialized_var() usage

2020-06-05 Thread Kalle Valo
Kees Cook writes: > Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppresses unrelated compiler warnings > (e.g. "unused variable"). If the compiler thinks it is uninitialized, > either simply initialize the variable or make compiler changes.

Re: [PATCH 09/10] treewide: Remove uninitialized_var() usage

2020-06-04 Thread Geert Uytterhoeven
Hi Kees, On Thu, Jun 4, 2020 at 5:01 PM Kees Cook wrote: > On Thu, Jun 04, 2020 at 10:23:06AM -0300, Jason Gunthorpe wrote: > > On Wed, Jun 03, 2020 at 04:32:02PM -0700, Kees Cook wrote: > > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > > > (or can in the future), and

Re: [PATCH 09/10] treewide: Remove uninitialized_var() usage

2020-06-04 Thread Jason Gunthorpe
On Thu, Jun 04, 2020 at 07:59:40AM -0700, Kees Cook wrote: > On Thu, Jun 04, 2020 at 10:23:06AM -0300, Jason Gunthorpe wrote: > > On Wed, Jun 03, 2020 at 04:32:02PM -0700, Kees Cook wrote: > > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > > > (or can in the future), and

Re: [PATCH 09/10] treewide: Remove uninitialized_var() usage

2020-06-04 Thread Kees Cook
On Thu, Jun 04, 2020 at 10:23:06AM -0300, Jason Gunthorpe wrote: > On Wed, Jun 03, 2020 at 04:32:02PM -0700, Kees Cook wrote: > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > > (or can in the future), and suppresses unrelated compiler warnings > > (e.g. "unused variable")

Re: [PATCH 09/10] treewide: Remove uninitialized_var() usage

2020-06-04 Thread Jason Gunthorpe
On Wed, Jun 03, 2020 at 04:32:02PM -0700, Kees Cook wrote: > Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppresses unrelated compiler warnings > (e.g. "unused variable"). If the compiler thinks it is uninitialized, > either simply initialize

Re: [PATCH 09/10] treewide: Remove uninitialized_var() usage

2020-06-04 Thread Leon Romanovsky
On Wed, Jun 03, 2020 at 04:32:02PM -0700, Kees Cook wrote: > Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppresses unrelated compiler warnings > (e.g. "unused variable"). If the compiler thinks it is uninitialized, > either simply initialize

Re: [PATCH 09/10] treewide: Remove uninitialized_var() usage

2020-06-03 Thread Kees Cook
On Wed, Jun 03, 2020 at 08:33:15PM -0700, Nathan Chancellor wrote: > On Wed, Jun 03, 2020 at 04:32:02PM -0700, Kees Cook wrote: > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > > (or can in the future), and suppresses unrelated compiler warnings > > (e.g. "unused variable

Re: [PATCH 09/10] treewide: Remove uninitialized_var() usage

2020-06-03 Thread Nathan Chancellor
On Wed, Jun 03, 2020 at 04:32:02PM -0700, Kees Cook wrote: > Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppresses unrelated compiler warnings > (e.g. "unused variable"). If the compiler thinks it is uninitialized, > either simply initialize

[PATCH 09/10] treewide: Remove uninitialized_var() usage

2020-06-03 Thread Kees Cook
Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. I preparation for removing[