Re: [PATCH 08/17] nfp: no need to check return value of debugfs_create functions

2019-08-06 Thread Jakub Kicinski
On Tue, 6 Aug 2019 19:00:49 +0200, Greg Kroah-Hartman wrote: > On Tue, Aug 06, 2019 at 09:50:08AM -0700, Jakub Kicinski wrote: > > On Tue, 6 Aug 2019 18:11:19 +0200, Greg Kroah-Hartman wrote: > > > When calling debugfs functions, there is no need to ever check the > > > return value. The functi

Re: [PATCH 08/17] nfp: no need to check return value of debugfs_create functions

2019-08-06 Thread Greg Kroah-Hartman
On Tue, Aug 06, 2019 at 09:50:08AM -0700, Jakub Kicinski wrote: > On Tue, 6 Aug 2019 18:11:19 +0200, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something di

Re: [PATCH 08/17] nfp: no need to check return value of debugfs_create functions

2019-08-06 Thread Jakub Kicinski
On Tue, 6 Aug 2019 18:11:19 +0200, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Jakub Kicinski > Cc: "David S. Miller"

[PATCH 08/17] nfp: no need to check return value of debugfs_create functions

2019-08-06 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Jakub Kicinski Cc: "David S. Miller" Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Jesper Dangaard Brouer