Re: [PATCH 07/16] esp4: Reorganize esp_output

2017-04-26 Thread Steffen Klassert
On Wed, Apr 26, 2017 at 11:52:47AM +, Ilan Tayari wrote: > > esp_output_head() might do an skb_cow, which then invalidates the esp.esph > pointer and causes a crash later on. > I would expect the ip_esp_hdr() call to be after the esp_output_head() call. > > But it seems like this pointer was

RE: [PATCH 07/16] esp4: Reorganize esp_output

2017-04-26 Thread Ilan Tayari
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > Subject: [PATCH 07/16] esp4: Reorganize esp_output > > We need a fallback for ESP at layer 2, so split esp_output into generic > functions that can be used at layer 3 and la

[PATCH 07/16] esp4: Reorganize esp_output

2017-04-20 Thread Steffen Klassert
We need a fallback for ESP at layer 2, so split esp_output into generic functions that can be used at layer 3 and layer 2 and use them in esp_output. We also add esp_xmit which is used for the layer 2 fallback. Signed-off-by: Steffen Klassert --- include/net/esp.h | 16 +++ net/ipv4/esp4.