On Tue, Jul 21, 2020 at 13:59:38 -0700, Jakub Kicinski wrote:
> On Tue, 21 Jul 2020 18:31:57 +0100 Tom Parkin wrote:
> > #if IS_ENABLED(CONFIG_IPV6)
> > - if (info->attrs[L2TP_ATTR_IP6_SADDR] &&
> > - info->attrs[L2TP_ATTR_IP6_DADDR]) {
> > - cfg.local_ip
From: Jakub Kicinski
Date: Tue, 21 Jul 2020 13:59:38 -0700
> Please split this submission into series of at most 15 patches at a
> time, to make sure reviewers don't get overloaded.
+1
On Tue, 21 Jul 2020 18:31:57 +0100 Tom Parkin wrote:
> #if IS_ENABLED(CONFIG_IPV6)
> - if (info->attrs[L2TP_ATTR_IP6_SADDR] &&
> - info->attrs[L2TP_ATTR_IP6_DADDR]) {
> - cfg.local_ip6 = nla_data(
> - info->attrs[L2TP_ATTR
Some l2tp code had line breaks which made the code more difficult to
read. These were originally motivated by the 80-character line width
coding guidelines, but were actually a negative from the perspective of
trying to follow the code.
Remove these linebreaks for clearer code, even if we do exce