Re: [PATCH 05/12] Support for NIC-specific code

2016-12-29 Thread David VomLehn
Responses inline. On 12/27/2016 09:21 PM, Rami Rosen wrote: Hi, David, Several nitpicks and comments, from a brief overview: The commented label //err_exit: should be removed +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c @@ -0,0 +1,993 @@ +//err_exit: +//err_exit: Shouldn't aq_nic_r

Re: [PATCH 05/12] Support for NIC-specific code

2016-12-27 Thread Rami Rosen
Hi, David, Several nitpicks and comments, from a brief overview: The commented label //err_exit: should be removed > +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c > @@ -0,0 +1,993 @@ > +//err_exit: > +//err_exit: Shouldn't aq_nic_rss_init() be static? isn't it called only from aq_nic_cf

[PATCH 05/12] Support for NIC-specific code

2016-12-27 Thread David VomLehn
Add support for code specific to the Atlantic NIC. Signed-off-by: Dmitrii Tarakanov Signed-off-by: Alexander Loktionov Signed-off-by: David M. VomLehn --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c| 993 + drivers/net/ethernet/aquantia/atlantic/aq_nic.h| 111 ++