Re: [ofa-general] Re: [PATCH 05/10] sch_generic.c changes.

2007-07-22 Thread Patrick McHardy
Krishna Kumar2 wrote: > Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007 11:46:36 PM: > >>The check for tx_queue_len is wrong though, >>its only a default which can be overriden and some qdiscs don't >>care for it at all. > > > I think it should not matter whether qdiscs use this or not,

Re: [PATCH 05/10] sch_generic.c changes.

2007-07-21 Thread Krishna Kumar2
Hi Patrick, Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007 11:46:36 PM: > Krishna Kumar wrote: > > +static inline int get_skb(struct net_device *dev, struct Qdisc *q, > > + struct sk_buff_head *blist, > > + struct sk_buff **skbp) > > +{ > > + if (likely(!blist) || (

Re: [PATCH 05/10] sch_generic.c changes.

2007-07-21 Thread Krishna Kumar2
Krishna Kumar2/India/IBM wrote on 07/21/2007 12:26:23 PM: > Hi Patrick, > > Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007 11:46:36 PM: > > > The check for tx_queue_len is wrong though, > > its only a default which can be overriden and some qdiscs don't > > care for it at all. > I think

Re: [PATCH 05/10] sch_generic.c changes.

2007-07-20 Thread Patrick McHardy
Krishna Kumar wrote: > +static inline int get_skb(struct net_device *dev, struct Qdisc *q, > + struct sk_buff_head *blist, > + struct sk_buff **skbp) > +{ > + if (likely(!blist) || (!skb_queue_len(blist) && qdisc_qlen(q) <= 1)) { > + retur

Re: [PATCH 05/10] sch_generic.c changes.

2007-07-20 Thread Krishna Kumar2
Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007 03:41:01 PM: > Krishna Kumar wrote: > > diff -ruNp org/net/sched/sch_generic.c new/net/sched/sch_generic.c > > --- org/net/sched/sch_generic.c 2007-07-20 07:49:28.0 +0530 > > +++ new/net/sched/sch_generic.c 2007-07-20 08:30:22.000

Re: [PATCH 05/10] sch_generic.c changes.

2007-07-20 Thread Patrick McHardy
Krishna Kumar2 wrote: Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007 03:41:01 PM: -static inline int qdisc_restart(struct net_device *dev) +static inline int qdisc_restart(struct net_device *dev, +struct sk_buff_head *blist) { struct Qdisc *q = dev->qdisc; struct

Re: [PATCH 05/10] sch_generic.c changes.

2007-07-20 Thread Patrick McHardy
Krishna Kumar wrote: > diff -ruNp org/net/sched/sch_generic.c new/net/sched/sch_generic.c > --- org/net/sched/sch_generic.c 2007-07-20 07:49:28.0 +0530 > +++ new/net/sched/sch_generic.c 2007-07-20 08:30:22.0 +0530 > @@ -9,6 +9,11 @@ > * Authors: Alexey Kuznetsov, <[EM

[PATCH 05/10] sch_generic.c changes.

2007-07-19 Thread Krishna Kumar
net/sched/sch_generic.c changes to support batching. Adds a batch aware function (get_skb) to get skbs to send. Signed-off-by: Krishna Kumar <[EMAIL PROTECTED]> --- sch_generic.c | 94 +++--- 1 files changed, 71 insertions(+), 23 deletions(-)