Re: [PATCH 02/11] bpf: Compile btfid tool at kernel compilation start

2020-06-19 Thread Jiri Olsa
On Thu, Jun 18, 2020 at 01:40:40PM -0700, John Fastabend wrote: > Jiri Olsa wrote: > > The btfid tool will be used during the vmlinux linking, > > so it's necessary it's ready for it. > > > > Signed-off-by: Jiri Olsa > > --- > > Makefile | 22 ++ > > tools/Makefile

Re: [PATCH 02/11] bpf: Compile btfid tool at kernel compilation start

2020-06-18 Thread Andrii Nakryiko
On Thu, Jun 18, 2020 at 7:08 PM Alexei Starovoitov wrote: > > On Thu, Jun 18, 2020 at 5:47 PM Arnaldo Carvalho de Melo > wrote: > > > > > > > > On June 18, 2020 9:40:32 PM GMT-03:00, Andrii Nakryiko > > wrote: > > >On Tue, Jun 16, 2020 at 3:06 AM Jiri Olsa wrote: > > >> > > >> The btfid tool w

Re: [PATCH 02/11] bpf: Compile btfid tool at kernel compilation start

2020-06-18 Thread Alexei Starovoitov
On Thu, Jun 18, 2020 at 5:47 PM Arnaldo Carvalho de Melo wrote: > > > > On June 18, 2020 9:40:32 PM GMT-03:00, Andrii Nakryiko > wrote: > >On Tue, Jun 16, 2020 at 3:06 AM Jiri Olsa wrote: > >> > >> The btfid tool will be used during the vmlinux linking, > >> so it's necessary it's ready for it.

Re: [PATCH 02/11] bpf: Compile btfid tool at kernel compilation start

2020-06-18 Thread Arnaldo Carvalho de Melo
On June 18, 2020 9:40:32 PM GMT-03:00, Andrii Nakryiko wrote: >On Tue, Jun 16, 2020 at 3:06 AM Jiri Olsa wrote: >> >> The btfid tool will be used during the vmlinux linking, >> so it's necessary it's ready for it. >> > >Seeing troubles John runs into, I wonder if it maybe would be better >to

Re: [PATCH 02/11] bpf: Compile btfid tool at kernel compilation start

2020-06-18 Thread Andrii Nakryiko
On Tue, Jun 16, 2020 at 3:06 AM Jiri Olsa wrote: > > The btfid tool will be used during the vmlinux linking, > so it's necessary it's ready for it. > Seeing troubles John runs into, I wonder if it maybe would be better to add it to pahole instead? It's already a dependency for anything BTF-relate

RE: [PATCH 02/11] bpf: Compile btfid tool at kernel compilation start

2020-06-18 Thread John Fastabend
John Fastabend wrote: > Jiri Olsa wrote: > > The btfid tool will be used during the vmlinux linking, > > so it's necessary it's ready for it. > > > > Signed-off-by: Jiri Olsa > > --- > > Makefile | 22 ++ > > tools/Makefile | 3 +++ > > tools/bpf/Makefile | 5

RE: [PATCH 02/11] bpf: Compile btfid tool at kernel compilation start

2020-06-18 Thread John Fastabend
Jiri Olsa wrote: > The btfid tool will be used during the vmlinux linking, > so it's necessary it's ready for it. > > Signed-off-by: Jiri Olsa > --- > Makefile | 22 ++ > tools/Makefile | 3 +++ > tools/bpf/Makefile | 5 - > 3 files changed, 25 insertions(

[PATCH 02/11] bpf: Compile btfid tool at kernel compilation start

2020-06-16 Thread Jiri Olsa
The btfid tool will be used during the vmlinux linking, so it's necessary it's ready for it. Signed-off-by: Jiri Olsa --- Makefile | 22 ++ tools/Makefile | 3 +++ tools/bpf/Makefile | 5 - 3 files changed, 25 insertions(+), 5 deletions(-) diff --git a/Ma