Laurent Pinchart wrote:
On Wednesday 06 February 2008 12:46, Jeff Garzik wrote:
two comments:
1) you should be using __le16 type
2) seems like you should do the same for RxStatus, rather than splitting it
The DM9000 datasheet (or rather the application notes) describes two distinct
fields,
On Tue, Feb 05, 2008 at 12:02:00AM +, Ben Dooks wrote:
> This patch splits the receive status in 8bit wide fields and convert the
> packet length from little endian to CPU byte order.
>
> Signed-off-by: Laurent Pinchart <[EMAIL PROTECTED]>
> Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
>
> In
On Wednesday 06 February 2008 12:46, Jeff Garzik wrote:
> two comments:
>
> 1) you should be using __le16 type
>
> 2) seems like you should do the same for RxStatus, rather than splitting it
The DM9000 datasheet (or rather the application notes) describes two distinct
fields, even though they bot
two comments:
1) you should be using __le16 type
2) seems like you should do the same for RxStatus, rather than splitting it
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordo
Ben Dooks <[EMAIL PROTECTED]> :
> This patch splits the receive status in 8bit wide fields and convert the
> packet length from little endian to CPU byte order.
>
> Signed-off-by: Laurent Pinchart <[EMAIL PROTECTED]>
> Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
>
> Index: linux-2.6.24-git5-dm9k
On Tue, Feb 05, 2008 at 12:02:00AM +, Ben Dooks wrote:
This should have been:
Patch From: Laurent Pinchart <[EMAIL PROTECTED]>
This patch splits the receive status in 8bit wide fields and convert the
packet length from little endian to CPU byte order.
Signed-off-by: Laurent Pinchart <[EMAIL
This patch splits the receive status in 8bit wide fields and convert the
packet length from little endian to CPU byte order.
Signed-off-by: Laurent Pinchart <[EMAIL PROTECTED]>
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.24-git5-dm9k/drivers/net/dm9000.c
