Re: [PATCH 0/4] clk-pmc-atom + r8169: Add ether_clk handling to fix suspend issues

2018-08-30 Thread Andy Shevchenko
On Wed, Aug 29, 2018 at 07:06:09PM +0200, Hans de Goede wrote: > > What a nice stuff, thanks! > > > > Reviewed-by: Andy Shevchenko > > Thank you (and also thank you for the other reviews) > > > Btw, you probably better to refer to > > https://bugzilla.kernel.org/show_bug.cgi?id=196861 which is

Re: [PATCH 0/4] clk-pmc-atom + r8169: Add ether_clk handling to fix suspend issues

2018-08-29 Thread Hans de Goede
Hi, On 29-08-18 18:31, Andy Shevchenko wrote: On Mon, Aug 27, 2018 at 04:31:56PM +0200, Hans de Goede wrote: Hi All, This series has as goal to revert commit d31fd43c0f9a ("clk: x86: Do not gate clocks enabled by the firmware"), because that commit causes almost all Cherry Trail devices to not

Re: [PATCH 0/4] clk-pmc-atom + r8169: Add ether_clk handling to fix suspend issues

2018-08-29 Thread Andy Shevchenko
On Mon, Aug 27, 2018 at 04:31:56PM +0200, Hans de Goede wrote: > Hi All, > > This series has as goal to revert commit d31fd43c0f9a ("clk: x86: Do not gate > clocks enabled by the firmware"), because that commit causes almost all > Cherry Trail devices to not use the S0i3 powerstate when suspending

[PATCH 0/4] clk-pmc-atom + r8169: Add ether_clk handling to fix suspend issues

2018-08-27 Thread Hans de Goede
Hi All, This series has as goal to revert commit d31fd43c0f9a ("clk: x86: Do not gate clocks enabled by the firmware"), because that commit causes almost all Cherry Trail devices to not use the S0i3 powerstate when suspending, leading to them quickly draining their battery when suspended. This co