Re: [PATCH 0/2] Use __scm_install_fd() more widely

2020-06-10 Thread Kees Cook
On Wed, Jun 10, 2020 at 11:38:00AM -0700, Jakub Kicinski wrote: > On Wed, 10 Jun 2020 10:03:03 -0700 Kees Cook wrote: > > If 0-day doesn't kick anything back on this tree, I'll resend the > > series... > > Well, 0-day may find more, but I can already tell you that patch 1 has > a checkpatch error:

Re: [PATCH 0/2] Use __scm_install_fd() more widely

2020-06-10 Thread Jakub Kicinski
On Wed, 10 Jun 2020 10:03:03 -0700 Kees Cook wrote: > If 0-day doesn't kick anything back on this tree, I'll resend the > series... Well, 0-day may find more, but I can already tell you that patch 1 has a checkpatch error: ERROR: "(foo*)" should be "(foo *)" #149: FILE: net/core/scm.c:323: +

Re: [PATCH 0/2] Use __scm_install_fd() more widely

2020-06-10 Thread Kees Cook
On Wed, Jun 10, 2020 at 11:47:35AM +0200, Christian Brauner wrote: > On Tue, Jun 09, 2020 at 09:52:12PM -0700, Kees Cook wrote: > > Hi, > > > > This extends the recent work hch did for scm_detach_fds(), and updates > > the compat path as well, fixing bugs in the process. Additionally, > > an effec

Re: [PATCH 0/2] Use __scm_install_fd() more widely

2020-06-10 Thread Kees Cook
On Wed, Jun 10, 2020 at 11:47:35AM +0200, Christian Brauner wrote: > On Tue, Jun 09, 2020 at 09:52:12PM -0700, Kees Cook wrote: > > Hi, > > > > This extends the recent work hch did for scm_detach_fds(), and updates > > the compat path as well, fixing bugs in the process. Additionally, > > an effec

Re: [PATCH 0/2] Use __scm_install_fd() more widely

2020-06-10 Thread Christian Brauner
On Tue, Jun 09, 2020 at 09:52:12PM -0700, Kees Cook wrote: > Hi, > > This extends the recent work hch did for scm_detach_fds(), and updates > the compat path as well, fixing bugs in the process. Additionally, > an effectively incomplete and open-coded __scm_install_fd() is fixed > in pidfd_getfd()

[PATCH 0/2] Use __scm_install_fd() more widely

2020-06-09 Thread Kees Cook
Hi, This extends the recent work hch did for scm_detach_fds(), and updates the compat path as well, fixing bugs in the process. Additionally, an effectively incomplete and open-coded __scm_install_fd() is fixed in pidfd_getfd(). Thanks! -Kees Kees Cook (2): net/scm: Regularize compat handling