Re: [PATCH -next] net: phy: Add missing of_node_put() in xgmiitorgmii_probe()

2016-08-21 Thread David Miller
From: Andrew Lunn Date: Sat, 20 Aug 2016 19:36:05 +0200 > On Sat, Aug 20, 2016 at 03:26:55PM +, Wei Yongjun wrote: >> This node pointer is returned by of_parse_phandle() with >> refcount incremented in this function. of_node_put() on it >> before exitting this function. > > Hi Wei > > You a

Re: [PATCH -next] net: phy: Add missing of_node_put() in xgmiitorgmii_probe()

2016-08-20 Thread Andrew Lunn
On Sat, Aug 20, 2016 at 03:26:55PM +, Wei Yongjun wrote: > This node pointer is returned by of_parse_phandle() with > refcount incremented in this function. of_node_put() on it > before exitting this function. Hi Wei You are only releasing on the error path. What about the successful path?

[PATCH -next] net: phy: Add missing of_node_put() in xgmiitorgmii_probe()

2016-08-20 Thread Wei Yongjun
This node pointer is returned by of_parse_phandle() with refcount incremented in this function. of_node_put() on it before exitting this function. This is detected by Coccinelle semantic patch. Signed-off-by: Wei Yongjun --- drivers/net/phy/xilinx_gmii2rgmii.c | 1 + 1 file changed, 1 insertion