Re: [PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-25 Thread Jeff Garzik
David Miller wrote: From: Joe Perches <[EMAIL PROTECTED]> Date: Tue, 25 Sep 2007 21:36:38 -0700 On Tue, 2007-09-25 at 19:29 -0700, David Miller wrote: I'm going to hold on this for now, there is no universal agreement that this is something we want to do and I'd like to take care of getting th

Re: [PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-25 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Tue, 25 Sep 2007 21:36:38 -0700 > On Tue, 2007-09-25 at 19:29 -0700, David Miller wrote: > > I'm going to hold on this for now, there is no universal > > agreement that this is something we want to do and I'd > > like to take care of getting the more cer

Re: [PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-25 Thread Joe Perches
On Tue, 2007-09-25 at 19:29 -0700, David Miller wrote: > I'm going to hold on this for now, there is no universal > agreement that this is something we want to do and I'd > like to take care of getting the more certain stuff into > net-2.6.24 before "iffy" bits like this one. Here's an argument fo

Re: [PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-25 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 23:53:31 -0700 > In the same vein as print_mac, the implementations > introduce declaration macros: I'm going to hold on this for now, there is no universal agreement that this is something we want to do and I'd like to take care of get

Re: [PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-20 Thread Joe Perches
On Fri, 2007-09-21 at 01:05 +0200, Thomas Graf wrote: > What exactly is the advantage of this? It makes the kernel image smaller and has consistency, typechecking and sparse advantages. print_mac(char *buf, const u8 *addr) print_ip(char *buf, __be32 addr) print_ipv6(char *buf, const u8 *addr) Cu

Re: [PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-20 Thread Thomas Graf
* Joe Perches <[EMAIL PROTECTED]> 2007-09-19 23:53 > In the same vein as print_mac, the implementations > introduce declaration macros: > DECLARE_IP_BUF(var) > DECLARE_IPV6_BUF(var) > and functions: > print_ip > print_ipv6 > print_ipv6_nofmt > > IPV4 Use: > > D

Re: [PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-20 Thread Ilpo Järvinen
On Thu, 20 Sep 2007, Joe Perches wrote: > On Thu, 2007-09-20 at 07:55 -0700, Randy Dunlap wrote: > > How large are the patches if you posted them for review instead > > of just referencing gits for them? (which cuts down on review > > possibilities) > > The v4 is ~130kb, the v6 ~35kb. > > There

Re: [PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-20 Thread Joe Perches
On Thu, 2007-09-20 at 07:55 -0700, Randy Dunlap wrote: > How large are the patches if you posted them for review instead > of just referencing gits for them? (which cuts down on review > possibilities) The v4 is ~130kb, the v6 ~35kb. There is a gitweb available at: print_ip: http://repo.or.cz/w

Re: [PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-20 Thread Randy Dunlap
On Wed, 19 Sep 2007 23:53:31 -0700 Joe Perches wrote: > In the same vein as print_mac, the implementations > introduce declaration macros: > DECLARE_IP_BUF(var) > DECLARE_IPV6_BUF(var) > and functions: > print_ip > print_ipv6 > print_ipv6_nofmt > > IPV4 Use: > >

[PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-19 Thread Joe Perches
In the same vein as print_mac, the implementations introduce declaration macros: DECLARE_IP_BUF(var) DECLARE_IPV6_BUF(var) and functions: print_ip print_ipv6 print_ipv6_nofmt IPV4 Use: DECLARE_IP_BUF(ipbuf); __be32 addr; print_ip(ipb