Re: [PATCH-2.4] Fix divide by 0 in vegas_cong_avoid()

2007-05-30 Thread Ilpo Järvinen
On Wed, 30 May 2007, Stephen Hemminger wrote: > On Wed, 30 May 2007 10:49:54 +0300 (EEST) > "Ilpo Järvinen" <[EMAIL PROTECTED]> wrote: > > > I think the code did a right thing before your api merge, since it called > > rtt callback only if FLAG_RETRANS_DATA_ACKED was not set (and pkts_acked > >

Re: [PATCH-2.4] Fix divide by 0 in vegas_cong_avoid()

2007-05-30 Thread Stephen Hemminger
On Wed, 30 May 2007 10:49:54 +0300 (EEST) "Ilpo Järvinen" <[EMAIL PROTECTED]> wrote: > On Tue, 29 May 2007, Stephen Hemminger wrote: > > > On Tue, 29 May 2007 20:23:45 +0200 > > "Lior Dotan" <[EMAIL PROTECTED]> wrote: > > > > > NTP was not running. I'm not sure what do you mean by fixing the -1.

Re: [PATCH-2.4] Fix divide by 0 in vegas_cong_avoid()

2007-05-30 Thread Ilpo Järvinen
On Tue, 29 May 2007, Stephen Hemminger wrote: > On Tue, 29 May 2007 20:23:45 +0200 > "Lior Dotan" <[EMAIL PROTECTED]> wrote: > > > NTP was not running. I'm not sure what do you mean by fixing the -1. > > The trace shows that vegas_cong_avoid() is called with -1, and the > > only way it can happen

Re: [PATCH-2.4] Fix divide by 0 in vegas_cong_avoid()

2007-05-29 Thread Stephen Hemminger
On Tue, 29 May 2007 20:23:45 +0200 "Lior Dotan" <[EMAIL PROTECTED]> wrote: > NTP was not running. I'm not sure what do you mean by fixing the -1. > The trace shows that vegas_cong_avoid() is called with -1, and the > only way it can happen is from tcp_clean_rtx_queue() and the patch > should elimi

Re: [PATCH-2.4] Fix divide by 0 in vegas_cong_avoid()

2007-05-29 Thread Stephen Hemminger
On Tue, 29 May 2007 12:18:19 +0300 "Lior Dotan" <[EMAIL PROTECTED]> wrote: > Hi, > > I had a divide by zero on kernel 2.4.33 running with Vegas enabled. > The KDB back trace is: > kdb> bt > Stack traceback for pid 0 > 0x403a600000 10 R 0x403a6370 *swapper > EBPEIP

Re: [PATCH-2.4] Fix divide by 0 in vegas_cong_avoid()

2007-05-29 Thread Lior Dotan
NTP was not running. I'm not sure what do you mean by fixing the -1. The trace shows that vegas_cong_avoid() is called with -1, and the only way it can happen is from tcp_clean_rtx_queue() and the patch should eliminate this. Another way of solving this is by checking vegas_rtt_calc() and see if i

Re: [PATCH-2.4] Fix divide by 0 in vegas_cong_avoid()

2007-05-29 Thread Stephen Hemminger
On Tue, 29 May 2007 12:18:19 +0300 "Lior Dotan" <[EMAIL PROTECTED]> wrote: > Hi, > > I had a divide by zero on kernel 2.4.33 running with Vegas enabled. > The KDB back trace is: > kdb> bt > Stack traceback for pid 0 > 0x403a600000 10 R 0x403a6370 *swapper > EBPEIP

[PATCH-2.4] Fix divide by 0 in vegas_cong_avoid()

2007-05-29 Thread Lior Dotan
Hi, I had a divide by zero on kernel 2.4.33 running with Vegas enabled. The KDB back trace is: kdb> bt Stack traceback for pid 0 0x403a600000 10 R 0x403a6370 *swapper EBPEIPFunction (args) 0x403a7d48 0x4026ae51 vegas_cong_avoid+0x111 (0x5f3bb638, 0x73c92cbb