Re: [PATCH] xprtrdma: fix incorrect header size calcations

2020-07-15 Thread Anna Schumaker
No need for a v2, I can fix it up! On Wed, Jul 15, 2020 at 12:32 PM Colin Ian King wrote: > > Bah, $SUBJECT typo "calcations" -> "calculations". can that be fixed up > when it's applied, or shall I send a V2? > > On 15/07/2020 17:26, Colin King wrote: > > From: Colin Ian King > > > > Currently

Re: [PATCH] xprtrdma: fix incorrect header size calcations

2020-07-15 Thread Chuck Lever
> On Jul 15, 2020, at 12:31 PM, Colin Ian King wrote: > > Bah, $SUBJECT typo "calcations" -> "calculations". can that be fixed up > when it's applied, or shall I send a V2? Anna's preference. Reviewed-by: Chuck Lever > On 15/07/2020 17:26, Colin King wrote: >> From: Colin Ian King >> >>

Re: [PATCH] xprtrdma: fix incorrect header size calcations

2020-07-15 Thread Colin Ian King
Bah, $SUBJECT typo "calcations" -> "calculations". can that be fixed up when it's applied, or shall I send a V2? On 15/07/2020 17:26, Colin King wrote: > From: Colin Ian King > > Currently the header size calculations are using an assignment > operator instead of a += operator when accumulating

[PATCH] xprtrdma: fix incorrect header size calcations

2020-07-15 Thread Colin King
From: Colin Ian King Currently the header size calculations are using an assignment operator instead of a += operator when accumulating the header size leading to incorrect sizes. Fix this by using the correct operator. Addresses-Coverity: ("Unused value") Fixes: 302d3deb2068 ("xprtrdma: Preven