Re: [PATCH] xfrm: fix the xfrm_policy/state_walk

2015-04-22 Thread Li RongQing
On Wed, Apr 22, 2015 at 3:57 PM, Herbert Xu wrote: >> Signed-off-by: Li RongQing > > This is not a bug fix but an optimisation. The walker entries are > all marked as dead and will be skipped by the loop. > > However, I don't see anything wrong with this optimisation. > > Cheers, thanks, you a

Re: [PATCH] xfrm: fix the xfrm_policy/state_walk

2015-04-22 Thread Herbert Xu
On Wed, Apr 22, 2015 at 03:53:34PM +0800, roy.qing...@gmail.com wrote: > From: Li RongQing > > If the walk from input is not empty, the following loop should start from > the walk->next, since walk is list header, and the last policy in previours > loop is connected walk tailor by list_move_tail(

[PATCH] xfrm: fix the xfrm_policy/state_walk

2015-04-22 Thread roy . qing . li
From: Li RongQing If the walk from input is not empty, the following loop should start from the walk->next, since walk is list header, and the last policy in previours loop is connected walk tailor by list_move_tail() Fixes: 12a169e7d8f(ipsec: Put dumpers on the dump list) Cc: Herbert Xu Signed