Re: [PATCH] vsock: ratelimit unknown ioctl error message

2020-10-26 Thread Jakub Kicinski
On Mon, 26 Oct 2020 19:24:57 +0100 Stefano Garzarella wrote: > @Colin, can you send a v2 removing the error message and updating the > return value? Not as a single patch, please, these are two different changes.

Re: [PATCH] vsock: ratelimit unknown ioctl error message

2020-10-26 Thread Stefano Garzarella
On Mon, Oct 26, 2020 at 10:55:48AM -0700, Jakub Kicinski wrote: On Mon, 26 Oct 2020 11:01:12 +0100 Stefano Garzarella wrote: On Mon, Oct 26, 2020 at 09:46:17AM +, David Laight wrote: >From: Stefano Garzarella >> Sent: 26 October 2020 09:39 >> >> On Mon, Oct 26, 2020 at 09:13:23AM +, Davi

Re: [PATCH] vsock: ratelimit unknown ioctl error message

2020-10-26 Thread Jakub Kicinski
On Mon, 26 Oct 2020 11:01:12 +0100 Stefano Garzarella wrote: > On Mon, Oct 26, 2020 at 09:46:17AM +, David Laight wrote: > >From: Stefano Garzarella > >> Sent: 26 October 2020 09:39 > >> > >> On Mon, Oct 26, 2020 at 09:13:23AM +, David Laight wrote: > >> >From: Stefano Garzarella > >>

Re: [PATCH] vsock: ratelimit unknown ioctl error message

2020-10-26 Thread Stefano Garzarella
On Mon, Oct 26, 2020 at 09:46:17AM +, David Laight wrote: From: Stefano Garzarella Sent: 26 October 2020 09:39 On Mon, Oct 26, 2020 at 09:13:23AM +, David Laight wrote: >From: Stefano Garzarella >> Sent: 26 October 2020 08:43 >... >> >Isn't the canonical error for unknown ioctl codes -E

RE: [PATCH] vsock: ratelimit unknown ioctl error message

2020-10-26 Thread David Laight
From: Stefano Garzarella > Sent: 26 October 2020 09:39 > > On Mon, Oct 26, 2020 at 09:13:23AM +, David Laight wrote: > >From: Stefano Garzarella > >> Sent: 26 October 2020 08:43 > >... > >> >Isn't the canonical error for unknown ioctl codes -ENOTTY? > >> > > >> > >> Oh, thanks for pointing tha

Re: [PATCH] vsock: ratelimit unknown ioctl error message

2020-10-26 Thread Stefano Garzarella
On Mon, Oct 26, 2020 at 09:13:23AM +, David Laight wrote: From: Stefano Garzarella Sent: 26 October 2020 08:43 ... >Isn't the canonical error for unknown ioctl codes -ENOTTY? > Oh, thanks for pointing that out! I had not paid attention to the error returned, but looking at it I noticed t

RE: [PATCH] vsock: ratelimit unknown ioctl error message

2020-10-26 Thread David Laight
From: Stefano Garzarella > Sent: 26 October 2020 08:43 ... > >Isn't the canonical error for unknown ioctl codes -ENOTTY? > > > > Oh, thanks for pointing that out! > > I had not paid attention to the error returned, but looking at it I > noticed that perhaps the most appropriate would be -ENOIOCTL

Re: [PATCH] vsock: ratelimit unknown ioctl error message

2020-10-26 Thread Stefano Garzarella
On Fri, Oct 23, 2020 at 09:30:59PM +, David Laight wrote: From: Stefano Garzarella Sent: 23 October 2020 15:10 On Fri, Oct 23, 2020 at 01:21:13PM +0100, Colin King wrote: >From: Colin Ian King > >When exercising the kernel with stress-ng with some ioctl tests the >"Unknown ioctl" error me

RE: [PATCH] vsock: ratelimit unknown ioctl error message

2020-10-23 Thread David Laight
From: Stefano Garzarella > Sent: 23 October 2020 15:10 > > On Fri, Oct 23, 2020 at 01:21:13PM +0100, Colin King wrote: > >From: Colin Ian King > > > >When exercising the kernel with stress-ng with some ioctl tests the > >"Unknown ioctl" error message is spamming the kernel log at a high > >rate

Re: [PATCH] vsock: ratelimit unknown ioctl error message

2020-10-23 Thread Jakub Kicinski
On Fri, 23 Oct 2020 16:09:47 +0200 Stefano Garzarella wrote: > On Fri, Oct 23, 2020 at 01:21:13PM +0100, Colin King wrote: > >From: Colin Ian King > > > >When exercising the kernel with stress-ng with some ioctl tests the > >"Unknown ioctl" error message is spamming the kernel log at a high > >rat

Re: [PATCH] vsock: ratelimit unknown ioctl error message

2020-10-23 Thread Stefano Garzarella
On Fri, Oct 23, 2020 at 01:21:13PM +0100, Colin King wrote: From: Colin Ian King When exercising the kernel with stress-ng with some ioctl tests the "Unknown ioctl" error message is spamming the kernel log at a high rate. Rate limit this message to reduce the noise. Signed-off-by: Colin Ian Ki

[PATCH] vsock: ratelimit unknown ioctl error message

2020-10-23 Thread Colin King
From: Colin Ian King When exercising the kernel with stress-ng with some ioctl tests the "Unknown ioctl" error message is spamming the kernel log at a high rate. Rate limit this message to reduce the noise. Signed-off-by: Colin Ian King --- net/vmw_vsock/af_vsock.c | 2 +- 1 file changed, 1 in