Re: [PATCH] vlan: fix potential race in vlan_cleanup_module vs vlan_ioctl_handler

2007-12-11 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 11:38:38 +0100 > Pavel Emelyanov wrote: > > AFAIS there's a tiny race window between these two > > calls - after rtnl unregistered all the vlans, but > > the ioctl handler isn't set to NULL yet, user can > > manage to call this ioc

Re: [PATCH] vlan: fix potential race in vlan_cleanup_module vs vlan_ioctl_handler

2007-12-11 Thread Patrick McHardy
Pavel Emelyanov wrote: The vlan module cleanup function starts with vlan_netlink_fini(); vlan_ioctl_set(NULL); The first call removes all the vlan devices and the second one closes the vlan ioctl. AFAIS there's a tiny race window between these two calls - after rtnl unregistere

[PATCH] vlan: fix potential race in vlan_cleanup_module vs vlan_ioctl_handler

2007-12-11 Thread Pavel Emelyanov
The vlan module cleanup function starts with vlan_netlink_fini(); vlan_ioctl_set(NULL); The first call removes all the vlan devices and the second one closes the vlan ioctl. AFAIS there's a tiny race window between these two calls - after rtnl unregistered all the vlans, but the