Re: [PATCH] via-velocity: unconditionally drop frames with bad l2 length

2015-11-17 Thread David Miller
From: Timo Teräs Date: Mon, 16 Nov 2015 14:36:32 +0200 > By default the driver allowed incorrect frames to be received. What is > worse the code does not handle very short frames correctly. The FCS > length is unconditionally subtracted, and the underflow can cause > skb_put to be called with lar

[PATCH] via-velocity: unconditionally drop frames with bad l2 length

2015-11-16 Thread Timo Teräs
By default the driver allowed incorrect frames to be received. What is worse the code does not handle very short frames correctly. The FCS length is unconditionally subtracted, and the underflow can cause skb_put to be called with large number after implicit cast to unsigned. And indeed, an skb_ove