Re: [PATCH] via-velocity: more cleanup

2007-09-28 Thread Jeff Garzik
Stephen Hemminger wrote: Per Al's suggestion, get rid of the stupid stuff: Remove cam_type switch, And deinline things that aren't important for speed. And make big macro and inline. And remove some dead/unused code. And use const char * for chip name. Signed-off-by: Stephen Hemminger <[EMAIL PR

Re: [PATCH] via-velocity: more cleanup

2007-08-24 Thread Al Viro
On Fri, Aug 24, 2007 at 02:40:45PM -0700, Stephen Hemminger wrote: > +static void mac_set_vlan_cam(struct mac_regs __iomem * regs, int idx, > + const u8 *addr) ITYM const u16 *, if not an outright u16. These casts (one below and ones in callers) really should die. > +

[PATCH] via-velocity: more cleanup

2007-08-24 Thread Stephen Hemminger
Per Al's suggestion, get rid of the stupid stuff: Remove cam_type switch, And deinline things that aren't important for speed. And make big macro and inline. And remove some dead/unused code. And use const char * for chip name. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/n