Re: [PATCH] veth: Optionally pad packets to minimum Ethernet length

2017-12-12 Thread Stephen Hemminger
On Tue, 12 Dec 2017 11:00:38 -0800 Ed Swierk wrote: > On Tue, Dec 12, 2017 at 10:34 AM, Stephen Hemminger > wrote: > > Why not add to netdevsim rather than cluttering up a normal driver > > with test support. We just pulled a bunch of test stuff out of dummy > > for the same reason. > > My t

Re: [PATCH] veth: Optionally pad packets to minimum Ethernet length

2017-12-12 Thread Cong Wang
On Tue, Dec 12, 2017 at 8:13 AM, Ed Swierk wrote: > Most physical Ethernet devices pad short packets to the minimum length > of 64 bytes (including FCS) on transmit. It can be useful to simulate > this behavior when debugging a problem that results from it (such as > incorrect L4 checksum calculat

Re: [PATCH] veth: Optionally pad packets to minimum Ethernet length

2017-12-12 Thread Ed Swierk
On Tue, Dec 12, 2017 at 10:34 AM, Stephen Hemminger wrote: > Why not add to netdevsim rather than cluttering up a normal driver > with test support. We just pulled a bunch of test stuff out of dummy > for the same reason. My test setup to trigger an openvswitch conntrack issue (https://marc.info

Re: [PATCH] veth: Optionally pad packets to minimum Ethernet length

2017-12-12 Thread Stephen Hemminger
On Tue, 12 Dec 2017 16:18:17 -0200 Marcelo Ricardo Leitner wrote: > On Tue, Dec 12, 2017 at 11:32:46AM -0600, Dan Williams wrote: > > On Tue, 2017-12-12 at 08:13 -0800, Ed Swierk wrote: > > > Most physical Ethernet devices pad short packets to the minimum > > > length > > > of 64 bytes (includi

Re: [PATCH] veth: Optionally pad packets to minimum Ethernet length

2017-12-12 Thread Marcelo Ricardo Leitner
On Tue, Dec 12, 2017 at 11:32:46AM -0600, Dan Williams wrote: > On Tue, 2017-12-12 at 08:13 -0800, Ed Swierk wrote: > > Most physical Ethernet devices pad short packets to the minimum > > length > > of 64 bytes (including FCS) on transmit. It can be useful to simulate > > this behavior when debuggi

Re: [PATCH] veth: Optionally pad packets to minimum Ethernet length

2017-12-12 Thread Dan Williams
On Tue, 2017-12-12 at 08:13 -0800, Ed Swierk wrote: > Most physical Ethernet devices pad short packets to the minimum > length > of 64 bytes (including FCS) on transmit. It can be useful to simulate > this behavior when debugging a problem that results from it (such as > incorrect L4 checksum calcu

[PATCH] veth: Optionally pad packets to minimum Ethernet length

2017-12-12 Thread Ed Swierk
Most physical Ethernet devices pad short packets to the minimum length of 64 bytes (including FCS) on transmit. It can be useful to simulate this behavior when debugging a problem that results from it (such as incorrect L4 checksum calculation). Padding is unnecessary for most applications so leav