Re: [PATCH] various dst_ifdown routines to catch refcounting bugs

2007-09-27 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Thu, 27 Sep 2007 10:27:43 -0600 > "Denis V. Lunev" <[EMAIL PROTECTED]> writes: > > > Moving dst entries into init_net.loopback_dev is not a good thing. > > This hides obvious and non-obvious ref-counting bugs. > > Acked-by: "Eric W. Biederman" <[

Re: [PATCH] various dst_ifdown routines to catch refcounting bugs

2007-09-27 Thread Eric W. Biederman
"Denis V. Lunev" <[EMAIL PROTECTED]> writes: > Moving dst entries into init_net.loopback_dev is not a good thing. > This hides obvious and non-obvious ref-counting bugs. Acked-by: "Eric W. Biederman" <[EMAIL PROTECTED]> To be clear using init_net.loopback is currently safe because we don't have

[PATCH] various dst_ifdown routines to catch refcounting bugs

2007-09-27 Thread Denis V. Lunev
Moving dst entries into init_net.loopback_dev is not a good thing. This hides obvious and non-obvious ref-counting bugs. This patch uses net_ns loopback instead of init_net loopback. This allowes to catch various bugs like recent one in IPv6 DAD handling. Signed-off-by: Denis V. Lunev <[EMAIL PR