Re: [PATCH] uapi: fix linux/if.h userspace compilation errors

2017-02-22 Thread David Miller
From: "Dmitry V. Levin" Date: Tue, 21 Feb 2017 23:19:14 +0300 > On Tue, Feb 21, 2017 at 12:10:22PM -0500, David Miller wrote: >> From: "Dmitry V. Levin" >> Date: Mon, 20 Feb 2017 14:58:41 +0300 >> >> > Include (guarded by ifndef __KERNEL__) to fix >> > the following linux/if.h userspace compil

Re: [PATCH] uapi: fix linux/if.h userspace compilation errors

2017-02-21 Thread Dmitry V. Levin
On Tue, Feb 21, 2017 at 11:19:14PM +0300, Dmitry V. Levin wrote: > On Tue, Feb 21, 2017 at 12:10:22PM -0500, David Miller wrote: > > From: "Dmitry V. Levin" > > Date: Mon, 20 Feb 2017 14:58:41 +0300 > > > > > Include (guarded by ifndef __KERNEL__) to fix > > > the following linux/if.h userspace

Re: [PATCH] uapi: fix linux/if.h userspace compilation errors

2017-02-21 Thread Dmitry V. Levin
On Tue, Feb 21, 2017 at 12:10:22PM -0500, David Miller wrote: > From: "Dmitry V. Levin" > Date: Mon, 20 Feb 2017 14:58:41 +0300 > > > Include (guarded by ifndef __KERNEL__) to fix > > the following linux/if.h userspace compilation errors: > > Wouldn't it be so much better to do this in include/

Re: [PATCH] uapi: fix linux/if.h userspace compilation errors

2017-02-21 Thread David Miller
From: "Dmitry V. Levin" Date: Mon, 20 Feb 2017 14:58:41 +0300 > Include (guarded by ifndef __KERNEL__) to fix > the following linux/if.h userspace compilation errors: Wouldn't it be so much better to do this in include/uapi/linux/socket.h? I mean, look at the comment right by the change you ar

[PATCH] uapi: fix linux/if.h userspace compilation errors

2017-02-20 Thread Dmitry V. Levin
Include (guarded by ifndef __KERNEL__) to fix the following linux/if.h userspace compilation errors: /usr/include/linux/if.h:234:19: error: field 'ifru_addr' has incomplete type struct sockaddr ifru_addr; /usr/include/linux/if.h:235:19: error: field 'ifru_dstaddr' has incomplete type struct