Re: [PATCH] tools/bpf/bpftool: Fix wrong return value in do_dump()

2020-08-03 Thread Daniel Borkmann
On 8/2/20 1:15 PM, Tianjia Zhang wrote: In case of btf_id does not exist, a negative error code -ENOENT should be returned. Fixes: c93cc69004df3 ("bpftool: add ability to dump BTF types") Cc: Andrii Nakryiko Signed-off-by: Tianjia Zhang Applied, thanks!

Re: [PATCH] tools/bpf/bpftool: Fix wrong return value in do_dump()

2020-08-03 Thread Tobias Klauser
On 2020-08-02 at 13:15:40 +0200, Tianjia Zhang wrote: > In case of btf_id does not exist, a negative error code -ENOENT > should be returned. > > Fixes: c93cc69004df3 ("bpftool: add ability to dump BTF types") > Cc: Andrii Nakryiko > Signed-off-by: Tianjia Zhang Reviewed-by: Tobias Klauser

Re: [PATCH] tools/bpf/bpftool: Fix wrong return value in do_dump()

2020-08-02 Thread John Fastabend
Andrii Nakryiko wrote: > On Sun, Aug 2, 2020 at 4:16 AM Tianjia Zhang > wrote: > > > > In case of btf_id does not exist, a negative error code -ENOENT > > should be returned. > > > > Fixes: c93cc69004df3 ("bpftool: add ability to dump BTF types") > > Cc: Andrii Nakryiko > > Signed-off-by: Tianjia

Re: [PATCH] tools/bpf/bpftool: Fix wrong return value in do_dump()

2020-08-02 Thread Andrii Nakryiko
On Sun, Aug 2, 2020 at 4:16 AM Tianjia Zhang wrote: > > In case of btf_id does not exist, a negative error code -ENOENT > should be returned. > > Fixes: c93cc69004df3 ("bpftool: add ability to dump BTF types") > Cc: Andrii Nakryiko > Signed-off-by: Tianjia Zhang > --- Acked-by: Andrii Nakryiko

[PATCH] tools/bpf/bpftool: Fix wrong return value in do_dump()

2020-08-02 Thread Tianjia Zhang
In case of btf_id does not exist, a negative error code -ENOENT should be returned. Fixes: c93cc69004df3 ("bpftool: add ability to dump BTF types") Cc: Andrii Nakryiko Signed-off-by: Tianjia Zhang --- tools/bpf/bpftool/btf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/to