Re: [PATCH] tcp: fix TCP_USER_TIMEOUT with zero window

2021-01-13 Thread Enke Chen
Hi, Eric: Yes, that is a good point! I have been discussing with Neal and Yuchung also and will work on revising the patch. Thanks. -- Enke On Wed, Jan 13, 2021 at 09:44:11PM +0100, Eric Dumazet wrote: > On Wed, Jan 13, 2021 at 9:12 PM Enke Chen wrote: > > > > From: Enke Chen > > > > The TCP

Re: [PATCH] tcp: fix TCP_USER_TIMEOUT with zero window

2021-01-13 Thread Enke Chen
Yes, I am convinced :-) Thanks to Eric, Neal and Yuchung for their help. -- Enke On Wed, Jan 13, 2021 at 01:20:55PM -0800, Yuchung Cheng wrote: > On Wed, Jan 13, 2021 at 12:49 PM Eric Dumazet wrote: > > > > On Wed, Jan 13, 2021 at 9:12 PM Enke Chen wrote: > > > > > > From: Enke Chen > > > > >

Re: [PATCH] tcp: fix TCP_USER_TIMEOUT with zero window

2021-01-13 Thread Enke Chen
Hi, Neal: Thank you for your detailed analysis and your help in coming up with the right fix. After going through multiple iterations of fixes and discussions, we are converging to using the timestamp for measuring the elapsed time. -- Enke On Wed, Jan 13, 2021 at 04:07:00PM -0500, Neal Cardwell

[PATCH] tcp: fix TCP_USER_TIMEOUT with zero window

2021-01-13 Thread Enke Chen
From: Enke Chen The TCP session does not terminate with TCP_USER_TIMEOUT when data remain untransmitted due to zero window. The number of unanswered zero-window probes (tcp_probes_out) is reset to zero with incoming acks irrespective of the window size, as described in tcp_probe_timer(): RF