Re: [PATCH] tcp: add tsval and tsecr to TCP_INFO

2019-10-02 Thread William Dauchy
On Thu, Oct 3, 2019 at 1:14 AM Eric Dumazet wrote: > I would rather use a new getsockopt() to fetch this specific data, > instead of making TCP_INFO bigger for everyone :/ > > ss command can dump millions of sockets in busy hosts, we need to be > careful of TCP_INFO size. Thanks Eric for your adv

Re: [PATCH] tcp: add tsval and tsecr to TCP_INFO

2019-10-02 Thread Eric Dumazet
On 10/2/19 3:54 PM, William Dauchy wrote: > Hello Eric, > > On Thu, Oct 3, 2019 at 12:33 AM Eric Dumazet wrote: >> On 10/2/19 3:10 PM, William Dauchy wrote: >> Reporting the last recorded values is really not good, >> a packet capture will give you all this information in a non >> racy way. >

Re: [PATCH] tcp: add tsval and tsecr to TCP_INFO

2019-10-02 Thread William Dauchy
Hello Eric, On Thu, Oct 3, 2019 at 12:33 AM Eric Dumazet wrote: > On 10/2/19 3:10 PM, William Dauchy wrote: > Reporting the last recorded values is really not good, > a packet capture will give you all this information in a non > racy way. Thank you for your quick answer. In my use case I use it

Re: [PATCH] tcp: add tsval and tsecr to TCP_INFO

2019-10-02 Thread Eric Dumazet
On 10/2/19 3:10 PM, William Dauchy wrote: > tsval and tsecr are useful in some cases to diagnose TCP issues from the > sender point of view where unexplained RTT values are seen. Getting the > the timestamps from both ends will help understand those issues more > easily. > Reporting the last r

[PATCH] tcp: add tsval and tsecr to TCP_INFO

2019-10-02 Thread William Dauchy
tsval and tsecr are useful in some cases to diagnose TCP issues from the sender point of view where unexplained RTT values are seen. Getting the the timestamps from both ends will help understand those issues more easily. Signed-off-by: William Dauchy --- include/uapi/linux/tcp.h | 3 +++ net/ip