Re: [PATCH] tc35815: Fix an usage of streaming DMA API.

2007-03-15 Thread Jeff Garzik
Atsushi Nemoto wrote: The tc35815 driver lacks a call to pci_dma_sync_single_for_device() on receiving. Recent fix of MIPS dma_sync_single_for_cpu() reveal this bug. Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]> --- This patch can be applied to netdev-2.6 tree or 2.6.21-rc3-mm2. applied t

Re: [PATCH] tc35815: Fix an usage of streaming DMA API.

2007-03-14 Thread Atsushi Nemoto
On Wed, 14 Mar 2007 05:59:51 -0400, Jeff Garzik <[EMAIL PROTECTED]> wrote: > > OK, Jeff, should I send a revised patch dropping this line? > > Nah, there's no need to reject the patch on that basis. > > You should send an additional patch, on top of all others you sent > recently, that completel

Re: [PATCH] tc35815: Fix an usage of streaming DMA API.

2007-03-14 Thread Jeff Garzik
Atsushi Nemoto wrote: On Tue, 13 Mar 2007 12:04:18 -0700, Stephen Hemminger <[EMAIL PROTECTED]> wrote: + * 1.35Fix an usage of streaming DMA API. */ Please don't use comments as changelog anymore. It gets out of date. The use of change control systems has made this practice obsolete.

Re: [PATCH] tc35815: Fix an usage of streaming DMA API.

2007-03-13 Thread Atsushi Nemoto
On Tue, 13 Mar 2007 12:04:18 -0700, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > + * 1.35Fix an usage of streaming DMA API. > > */ > > Please don't use comments as changelog anymore. It gets out of date. > The use of change control systems has made this practice obsolete. OK, Jeff, shou

Re: [PATCH] tc35815: Fix an usage of streaming DMA API.

2007-03-13 Thread Stephen Hemminger
On Wed, 14 Mar 2007 01:02:20 +0900 (JST) Atsushi Nemoto <[EMAIL PROTECTED]> wrote: > The tc35815 driver lacks a call to pci_dma_sync_single_for_device() on > receiving. Recent fix of MIPS dma_sync_single_for_cpu() reveal this > bug. > > Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]> > --- > T

[PATCH] tc35815: Fix an usage of streaming DMA API.

2007-03-13 Thread Atsushi Nemoto
The tc35815 driver lacks a call to pci_dma_sync_single_for_device() on receiving. Recent fix of MIPS dma_sync_single_for_cpu() reveal this bug. Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]> --- This patch can be applied to netdev-2.6 tree or 2.6.21-rc3-mm2. diff --git a/drivers/net/tc35815.c