Re: [PATCH] sungem: fix napi regression with reset work

2007-12-03 Thread Johannes Berg
On Thu, 2007-11-29 at 21:57 +1100, Herbert Xu wrote: > On Mon, Nov 26, 2007 at 09:02:08PM +0100, Johannes Berg wrote: > > sungem's gem_reset_task() will unconditionally try to disable NAPI even > > when it's called while the interface is not operating and hence the NAPI > > struct isn't enabled. M

Re: [PATCH] sungem: fix napi regression with reset work

2007-11-29 Thread Herbert Xu
On Mon, Nov 26, 2007 at 09:02:08PM +0100, Johannes Berg wrote: > sungem's gem_reset_task() will unconditionally try to disable NAPI even > when it's called while the interface is not operating and hence the NAPI > struct isn't enabled. Make napi_disable() depend on gp->running. > > Also removes a

Re: [PATCH] sungem: fix napi regression with reset work

2007-11-27 Thread Benjamin Herrenschmidt
On Mon, 2007-11-26 at 21:02 +0100, Johannes Berg wrote: > sungem's gem_reset_task() will unconditionally try to disable NAPI even > when it's called while the interface is not operating and hence the NAPI > struct isn't enabled. Make napi_disable() depend on gp->running. > > Also removes a superf

[PATCH] sungem: fix napi regression with reset work

2007-11-27 Thread Johannes Berg
sungem's gem_reset_task() will unconditionally try to disable NAPI even when it's called while the interface is not operating and hence the NAPI struct isn't enabled. Make napi_disable() depend on gp->running. Also removes a superfluous test of gp->running in the same function. Signed-off-by: Joh