[PATCH] spidernet: enable poll() before registering interrupts

2007-08-21 Thread Ishizaki Kou
We must not call netif_poll_enable after enabling interrupts, because an interrupt might come in and set the __LINK_STATE_RX_SCHED bit before we get to clear that bit again. If that happens, the next call to the ->poll() function will oops. Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]> Signed-o

Re: [PATCH] spidernet: enable poll() before registering interrupts

2007-08-20 Thread Arnd Bergmann
On Tuesday 21 August 2007, Linas Vepstas wrote: > > An intervening patch changed the init so that the > hardware interrupts aren't enabled until after the > request_irq, and after the poll_enable().  Thus, > it seems this pach is no longer needed, right? Right, the other patch that you already a

Re: [PATCH] spidernet: enable poll() before registering interrupts

2007-08-20 Thread Linas Vepstas
On Thu, Jul 12, 2007 at 01:19:11AM +0200, Arnd Bergmann wrote: > We must not call netif_poll_enable after enabling interrupts, > because an interrupt might come in and set the __LINK_STATE_RX_SCHED > bit before we get to clear that bit again. If that happens, > the next call to the ->poll() functio

Re: [PATCH] spidernet: enable poll() before registering interrupts

2007-08-20 Thread Linas Vepstas
On Thu, Jul 12, 2007 at 01:19:11AM +0200, Arnd Bergmann wrote: > Index: linux-2.6/drivers/net/spider_net.c Sorry, this one got lost in my mailbox. Will attend to it shortly. --linas - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED]

[PATCH] spidernet: enable poll() before registering interrupts

2007-07-11 Thread Arnd Bergmann
We must not call netif_poll_enable after enabling interrupts, because an interrupt might come in and set the __LINK_STATE_RX_SCHED bit before we get to clear that bit again. If that happens, the next call to the ->poll() function will oops. Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]> --- This