Re: [PATCH] socket: fix struct ifreq size in compat ioctl

2018-09-13 Thread kbuild test robot
Hi Johannes, I love your patch! Yet something to improve: [auto build test ERROR on net/master] [also build test ERROR on v4.19-rc3 next-20180913] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [PATCH] socket: fix struct ifreq size in compat ioctl

2018-09-13 Thread Johannes Berg
On Thu, 2018-09-13 at 13:13 +0100, Al Viro wrote: > On Thu, Sep 13, 2018 at 01:49:09PM +0200, Johannes Berg wrote: > > From: Johannes Berg > > > > As reported by Reobert O'Callahan, since Viro's commit to kill > > dev_ifsioc() we attempt to copy too much data in compat mode, > > which may lead to

Re: [PATCH] socket: fix struct ifreq size in compat ioctl

2018-09-13 Thread Al Viro
On Thu, Sep 13, 2018 at 01:49:09PM +0200, Johannes Berg wrote: > From: Johannes Berg > > As reported by Reobert O'Callahan, since Viro's commit to kill > dev_ifsioc() we attempt to copy too much data in compat mode, > which may lead to EFAULT when the 32-bit version of struct ifreq > sits at/near

[PATCH] socket: fix struct ifreq size in compat ioctl

2018-09-13 Thread Johannes Berg
From: Johannes Berg As reported by Reobert O'Callahan, since Viro's commit to kill dev_ifsioc() we attempt to copy too much data in compat mode, which may lead to EFAULT when the 32-bit version of struct ifreq sits at/near the end of a page boundary, and the next page isn't mapped. Fix this by p