Re: [PATCH] sit: correct IP protocol used in ipip6_err

2016-06-16 Thread David Miller
From: Simon Horman Date: Thu, 16 Jun 2016 17:06:19 +0900 > Since 32b8a8e59c9c ("sit: add IPv4 over IPv4 support") > ipip6_err() may be called for packets whose IP protocol is > IPPROTO_IPIP as well as those whose IP protocol is IPPROTO_IPV6. > > In the case of IPPROTO_IPIP packets the correct pr

Re: [PATCH] sit: correct IP protocol used in ipip6_err

2016-06-16 Thread Simon Horman
On Thu, Jun 16, 2016 at 05:23:13PM +0900, YOSHIFUJI Hideaki wrote: > Hi, Simon, > > Simon Horman wrote: > > On Thu, Jun 16, 2016 at 05:06:19PM +0900, Simon Horman wrote: > >> Since 32b8a8e59c9c ("sit: add IPv4 over IPv4 support") > >> ipip6_err() may be called for packets whose IP protocol is > >>

Re: [PATCH] sit: correct IP protocol used in ipip6_err

2016-06-16 Thread YOSHIFUJI Hideaki
Hi, Simon, Simon Horman wrote: > On Thu, Jun 16, 2016 at 05:06:19PM +0900, Simon Horman wrote: >> Since 32b8a8e59c9c ("sit: add IPv4 over IPv4 support") >> ipip6_err() may be called for packets whose IP protocol is >> IPPROTO_IPIP as well as those whose IP protocol is IPPROTO_IPV6. >> >> In the ca

Re: [PATCH] sit: correct IP protocol used in ipip6_err

2016-06-16 Thread Simon Horman
On Thu, Jun 16, 2016 at 05:06:19PM +0900, Simon Horman wrote: > Since 32b8a8e59c9c ("sit: add IPv4 over IPv4 support") > ipip6_err() may be called for packets whose IP protocol is > IPPROTO_IPIP as well as those whose IP protocol is IPPROTO_IPV6. > > In the case of IPPROTO_IPIP packets the correct

[PATCH] sit: correct IP protocol used in ipip6_err

2016-06-16 Thread Simon Horman
Since 32b8a8e59c9c ("sit: add IPv4 over IPv4 support") ipip6_err() may be called for packets whose IP protocol is IPPROTO_IPIP as well as those whose IP protocol is IPPROTO_IPV6. In the case of IPPROTO_IPIP packets the correct protocol value is not passed to ipv4_update_pmtu() or ipv4_redirect().