Re: [PATCH] sis900: increment revision number

2019-06-23 Thread Joe Perches
On Sun, 2019-06-23 at 08:37 -0700, David Miller wrote: > From: Daniele Venzano > Date: Sun, 23 Jun 2019 11:13:28 +0200 > > > Hello, > > > > I think it is good to know just by looking at the sources that the > > driver is still kept up-to-date, so I am in favor of this patch. > > I absolutely, s

Re: [PATCH] sis900: increment revision number

2019-06-23 Thread David Miller
From: Daniele Venzano Date: Sun, 23 Jun 2019 11:13:28 +0200 > Hello, > > I think it is good to know just by looking at the sources that the > driver is still kept up-to-date, so I am in favor of this patch. I absolutely, strongly, disagree. These are pointless.

Re: [PATCH] sis900: increment revision number

2019-06-23 Thread David Miller
From: Sergej Benilov Date: Sun, 23 Jun 2019 09:47:07 +0200 > Increment revision number to 1.08.11 (TX completion fix). > > Signed-off-by: Sergej Benilov These are useless, really... People are going to backport the TX completion fix all by itself and not this change if I were to merge it. I

Re: [PATCH] sis900: increment revision number

2019-06-23 Thread Daniele Venzano
Hello, I think it is good to know just by looking at the sources that the driver is still kept up-to-date, so I am in favor of this patch. Daniele On 23/06/2019 11:10, Joe Perches wrote: On Sun, 2019-06-23 at 09:47 +0200, Sergej Benilov wrote: Increment revision number to 1.08.11 (TX comple

Re: [PATCH] sis900: increment revision number

2019-06-23 Thread Joe Perches
On Sun, 2019-06-23 at 09:47 +0200, Sergej Benilov wrote: > Increment revision number to 1.08.11 (TX completion fix). Better not to bother as the last increment was in 2006. The driver version gets the kernel version in any case. > diff --git a/drivers/net/ethernet/sis/sis900.c > b/drivers/net/et

Re: [PATCH] sis900: increment revision number

2019-06-23 Thread Daniele Venzano
Sorry to be late in replying, I am ok also with the previous changes. Signed-off-by: Daniele Venzano On 23/06/2019 09:47, Sergej Benilov wrote: Increment revision number to 1.08.11 (TX completion fix). Signed-off-by: Sergej Benilov --- drivers/net/ethernet/sis/sis900.c | 7 --- 1 file

[PATCH] sis900: increment revision number

2019-06-23 Thread Sergej Benilov
Increment revision number to 1.08.11 (TX completion fix). Signed-off-by: Sergej Benilov --- drivers/net/ethernet/sis/sis900.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c index abb9b42e..09b4e1c5