Re: [PATCH] sh_eth: fix descriptor access endianness

2015-12-15 Thread Sergei Shtylyov
Hello. On 12/15/2015 09:06 PM, Sergei Shtylyov wrote: The driver never calls cpu_to_edmac() when writing the descriptor address and edmac_to_cpu() when reading it, although it should -- fix this. Note that the frame/buffer length descriptor field accesses also need fixing but since they are bo

Re: [PATCH] sh_eth: fix descriptor access endianness

2015-12-15 Thread David Miller
From: Sergei Shtylyov Date: Tue, 15 Dec 2015 14:26:51 +0300 > Hello. > > On 12/15/2015 8:25 AM, David Miller wrote: > >>> The driver never calls cpu_to_edmac() when writing the descriptor >>> address >>> and edmac_to_cpu() when reading it, although it should -- fix this. >>> >>> Note that the f

Re: [PATCH] sh_eth: fix descriptor access endianness

2015-12-15 Thread David Miller
From: Sergei Shtylyov Date: Tue, 15 Dec 2015 21:06:16 +0300 > On 12/15/2015 08:53 PM, David Miller wrote: > > The driver never calls cpu_to_edmac() when writing the descriptor > address > and edmac_to_cpu() when reading it, although it should -- fix this. > > Note that the fr

Re: [PATCH] sh_eth: fix descriptor access endianness

2015-12-15 Thread Sergei Shtylyov
On 12/15/2015 08:53 PM, David Miller wrote: The driver never calls cpu_to_edmac() when writing the descriptor address and edmac_to_cpu() when reading it, although it should -- fix this. Note that the frame/buffer length descriptor field accesses also need fixing but since they are both 16-bit w

Re: [PATCH] sh_eth: fix descriptor access endianness

2015-12-15 Thread Sergei Shtylyov
Hello. On 12/15/2015 8:25 AM, David Miller wrote: The driver never calls cpu_to_edmac() when writing the descriptor address and edmac_to_cpu() when reading it, although it should -- fix this. Note that the frame/buffer length descriptor field accesses also need fixing but since they are both

Re: [PATCH] sh_eth: fix descriptor access endianness

2015-12-14 Thread David Miller
From: Sergei Shtylyov Date: Sun, 13 Dec 2015 23:05:07 +0300 > The driver never calls cpu_to_edmac() when writing the descriptor address > and edmac_to_cpu() when reading it, although it should -- fix this. > > Note that the frame/buffer length descriptor field accesses also need fixing > but si

Re: [PATCH] sh_eth: fix descriptor access endianness

2015-12-14 Thread Sergei Shtylyov
Hello. On 12/13/2015 11:05 PM, Sergei Shtylyov wrote: The driver never calls cpu_to_edmac() when writing the descriptor address and edmac_to_cpu() when reading it, although it should -- fix this. Note that the frame/buffer length descriptor field accesses also need fixing but since they are b

[PATCH] sh_eth: fix descriptor access endianness

2015-12-13 Thread Sergei Shtylyov
The driver never calls cpu_to_edmac() when writing the descriptor address and edmac_to_cpu() when reading it, although it should -- fix this. Note that the frame/buffer length descriptor field accesses also need fixing but since they are both 16-bit we can't use {cpu|edmac}_to_{edmac|cpu}()...