On 12/12/2016 06:49 PM, Niklas Söderlund wrote:
Thanks for your feedback.
Not at all, it's my duty now. :-)
I should probably have warned you not to post the new version to netdev --
DaveM has closed his net-next.git tree (ahead of the usual time, which would
have been 4.9 release), so
Hi Sergei,
Thanks for your feedback.
On 2016-12-11 00:25:41 +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 12/08/2016 05:56 PM, Niklas Söderlund wrote:
>
> > > You only enable the WOL support fo the R-Car gen2 chips but never say
> > > that
> > > explicitly, neither in the subject nor here.
>
Hello!
On 12/08/2016 05:56 PM, Niklas Söderlund wrote:
You only enable the WOL support fo the R-Car gen2 chips but never say that
explicitly, neither in the subject nor here.
Signed-off-by: Niklas Söderlund
---
drivers/net/ethernet/renesas/sh_eth.c | 120 +++---
On 12/08/2016 03:28 PM, Sergei Shtylyov wrote:
Good to see that somebody cares still about this driver, one more task off
my back. :-)
On 12/07/2016 07:28 PM, Niklas Söderlund wrote:
You only enable the WOL support fo the R-Car gen2 chips but never say that
explicitly, neither in the subj
On Thu, Dec 08, 2016 at 04:01:05PM +0100, Niklas Söderlund wrote:
> Hi Simon,
>
> Thanks for your feedback.
>
> On 2016-12-08 14:22:44 +0100, Simon Horman wrote:
>
>
>
> > > >
> > > > > --- a/drivers/net/ethernet/renesas/sh_eth.h
> > > > > +++ b/drivers/net/ethernet/renesas/sh_eth.h
> > > > >
On Thu, Dec 8, 2016 at 3:56 PM, Niklas Söderlund
wrote:
>> > + /* Increased clock usage so device won't be suspended */
>> > + clk_enable(mdp->clk);
>>
>>Hum, intermixiggn runtime PM with clock API doesn't look good...
>
> I agree it looks weird but I need a way to increment the usage coun
Hi Simon,
Thanks for your feedback.
On 2016-12-08 14:22:44 +0100, Simon Horman wrote:
> > >
> > > > --- a/drivers/net/ethernet/renesas/sh_eth.h
> > > > +++ b/drivers/net/ethernet/renesas/sh_eth.h
> > > > @@ -493,6 +493,7 @@ struct sh_eth_cpu_data {
> > > > unsigned shift_rd0:1; /* s
Hi Sergei,
Thanks for your feedback.
On 2016-12-08 15:28:48 +0300, Sergei Shtylyov wrote:
> Hello!
>
>Good to see that somebody cares still about this driver, one more task
> off my back. :-)
>
> On 12/07/2016 07:28 PM, Niklas Söderlund wrote:
>
> You only enable the WOL support fo the R
On do, dec 08, 2016 at 08:16:20 +0100, Niklas Söderlund wrote:
> Hi Geert,
>
> Thanks for testing and your feedback.
>
> On 2016-12-07 19:14:40 +0100, Geert Uytterhoeven wrote:
> > Hi Niklas,
> >
> > On Wed, Dec 7, 2016 at 5:28 PM, Niklas Söderlund
> > wrote:
> > > Signed-off-by: Niklas Söderlu
Hello!
Good to see that somebody cares still about this driver, one more task off
my back. :-)
On 12/07/2016 07:28 PM, Niklas Söderlund wrote:
You only enable the WOL support fo the R-Car gen2 chips but never say that
explicitly, neither in the subject nor here.
Signed-off-by: Niklas
Hi Geert,
Thanks for testing and your feedback.
On 2016-12-07 19:14:40 +0100, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> On Wed, Dec 7, 2016 at 5:28 PM, Niklas Söderlund
> wrote:
> > Signed-off-by: Niklas Söderlund
>
> Thanks, works fine on r8a7791/koelsch!
>
> Tested-by: Geert Uytterhoeven
Hi Niklas,
On Wed, Dec 7, 2016 at 5:28 PM, Niklas Söderlund
wrote:
> Signed-off-by: Niklas Söderlund
Thanks, works fine on r8a7791/koelsch!
Tested-by: Geert Uytterhoeven
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -624,7 +624,7 @@ static s
Signed-off-by: Niklas Söderlund
---
drivers/net/ethernet/renesas/sh_eth.c | 120 +++---
drivers/net/ethernet/renesas/sh_eth.h | 4 ++
2 files changed, 116 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/renesas/sh_eth.c
b/drivers/net/ethernet/renesa
13 matches
Mail list logo
