Re: [PATCH] selftest/bpf: fix IPV6FR handling in flow dissector

2020-11-12 Thread John Fastabend
Jakub Sitnicki wrote: > On Thu, Nov 12, 2020 at 12:06 AM CET, Daniel Borkmann wrote: > > [...] > > >>> I'm not initimately familiar with this test, but looking at the change > >>> I'd consider that Destinations Options and encapsulation headers can > >>> follow the Fragment Header. > >>> > >>> Wi

Re: [PATCH] selftest/bpf: fix IPV6FR handling in flow dissector

2020-11-12 Thread Jakub Sitnicki
On Thu, Nov 12, 2020 at 12:06 AM CET, Daniel Borkmann wrote: [...] >>> I'm not initimately familiar with this test, but looking at the change >>> I'd consider that Destinations Options and encapsulation headers can >>> follow the Fragment Header. >>> >>> With enough of Dst Opts or levels of encap

Re: [PATCH] selftest/bpf: fix IPV6FR handling in flow dissector

2020-11-11 Thread Daniel Borkmann
On 11/11/20 3:12 PM, Santucci Pierpaolo wrote: Hi Jakub, thanks for your reply. (Santucci, please do not top-post but always reply inline which makes it easier for discussions to follow.) Let me explain the problem with an example. Please consider the PCAP file: https://github.com/named-da

Re: [PATCH] selftest/bpf: fix IPV6FR handling in flow dissector

2020-11-11 Thread Santucci Pierpaolo
Hi Jakub, thanks for your reply. Let me explain the problem with an example. Please consider the PCAP file: https://github.com/named-data/ndn-tools/blob/master/tests/dissect-wireshark/ipv6-udp-fragmented.pcap Let's assume that the dissector is invoked without the flag: BPF_FLOW_DISSECTOR_F_STOP_

Re: [PATCH] selftest/bpf: fix IPV6FR handling in flow dissector

2020-11-11 Thread Jakub Sitnicki
On Wed, Nov 11, 2020 at 05:48 AM CET, Andrii Nakryiko wrote: > On Tue, Nov 10, 2020 at 9:12 AM Santucci Pierpaolo > wrote: >> >> From second fragment on, IPV6FR program must stop the dissection of IPV6 >> fragmented packet. This is the same approach used for IPV4 fragmentation. >> > > Jakub, can y

Re: [PATCH] selftest/bpf: fix IPV6FR handling in flow dissector

2020-11-10 Thread Andrii Nakryiko
On Tue, Nov 10, 2020 at 9:12 AM Santucci Pierpaolo wrote: > > From second fragment on, IPV6FR program must stop the dissection of IPV6 > fragmented packet. This is the same approach used for IPV4 fragmentation. > Jakub, can you please take a look as well? > Signed-off-by: Santucci Pierpaolo > -

[PATCH] selftest/bpf: fix IPV6FR handling in flow dissector

2020-11-10 Thread Santucci Pierpaolo
>From second fragment on, IPV6FR program must stop the dissection of IPV6 fragmented packet. This is the same approach used for IPV4 fragmentation. Signed-off-by: Santucci Pierpaolo --- tools/testing/selftests/bpf/progs/bpf_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testi