RE: [PATCH] rtw88: fix fw_fifo_addr check

2020-10-13 Thread Andy Huang
> On Sun, Oct 11, 2020 at 08:54:38AM -0700, t...@redhat.com wrote: > > From: Tom Rix > > > > The clang build reports this warning > > > > fw.c:1485:21: warning: address of array 'rtwdev->chip->fw_fifo_addr' > > will always evaluate to 'true' > > if (!rtwdev->chip->fw_fifo_addr) { > > >

Re: [PATCH] rtw88: fix fw_fifo_addr check

2020-10-11 Thread Nathan Chancellor
On Sun, Oct 11, 2020 at 08:54:38AM -0700, t...@redhat.com wrote: > From: Tom Rix > > The clang build reports this warning > > fw.c:1485:21: warning: address of array 'rtwdev->chip->fw_fifo_addr' > will always evaluate to 'true' > if (!rtwdev->chip->fw_fifo_addr) { > > fw_fifo_addr is

[PATCH] rtw88: fix fw_fifo_addr check

2020-10-11 Thread trix
From: Tom Rix The clang build reports this warning fw.c:1485:21: warning: address of array 'rtwdev->chip->fw_fifo_addr' will always evaluate to 'true' if (!rtwdev->chip->fw_fifo_addr) { fw_fifo_addr is an array in rtw_chip_info so it is always nonzero. A better check is if the first