Re: [PATCH] rtlwifi: Fix reusable codes in core.c

2016-02-02 Thread Julian Calaby
Hi ByeoungWook, On Wed, Feb 3, 2016 at 11:52 AM, ByeoungWook Kim wrote: > Hi Julian, > > 0xfe and 0xfb was not same codes. > 0xfe is udelay(50). and 0xfb is mdelay(50). > It same code like udelay((n) * 1000). I'm clearly blind! Sorry about that! > but i agree with your answers of some parts. I

Re: [PATCH] rtlwifi: Fix reusable codes in core.c

2016-02-02 Thread Julian Calaby
Hi Byeoungwook, On Wed, Feb 3, 2016 at 2:48 AM, Byeoungwook Kim wrote: > rtl_*_delay() functions were reused same codes about addr variable. > So i have converted to rtl_addr_delay() from code about addr variable. > > Conditional codes in rtl_addr_delay() were improved in readability and > perfor

[PATCH] rtlwifi: Fix reusable codes in core.c

2016-02-02 Thread Byeoungwook Kim
rtl_*_delay() functions were reused same codes about addr variable. So i have converted to rtl_addr_delay() from code about addr variable. Conditional codes in rtl_addr_delay() were improved in readability and performance by using switch codes. Signed-off-by: Byeoungwook Kim --- drivers/net/wir