Re: [PATCH] rt2x00: reset reg earlier in rt2500usb_register_read

2021-01-21 Thread Greg KH
On Thu, Jan 21, 2021 at 06:52:46PM +0800, Dongliang Mu wrote: > In the function rt2500usb_register_read(_lock), reg is uninitialized > in some situation. Then KMSAN reports uninit-value at its first memory > access. To fix this issue, initialize reg with zero in the function > rt2500usb_register_re

Re: [PATCH] rt2x00: reset reg earlier in rt2500usb_register_read

2021-01-21 Thread Greg KH
On Thu, Jan 21, 2021 at 06:59:08PM +0800, 慕冬亮 wrote: > On Thu, Jan 21, 2021 at 5:49 PM Greg KH wrote: > > > > On Thu, Jan 21, 2021 at 05:20:26PM +0800, Dongliang Mu wrote: > > > In the function rt2500usb_register_read(_lock), reg is uninitialized > > > in some situation. Then KMSAN reports uninit-

Re: [PATCH] rt2x00: reset reg earlier in rt2500usb_register_read

2021-01-21 Thread 慕冬亮
On Thu, Jan 21, 2021 at 7:21 PM Greg KH wrote: > > On Thu, Jan 21, 2021 at 06:59:08PM +0800, 慕冬亮 wrote: > > > > rt2x00usb_vendor_request_buff(rt2x00dev, USB_MULTI_READ, > > > > USB_VENDOR_REQUEST_IN, offset, > > > > ®, s

Re: [PATCH] rt2x00: reset reg earlier in rt2500usb_register_read

2021-01-21 Thread Greg KH
On Thu, Jan 21, 2021 at 06:59:08PM +0800, 慕冬亮 wrote: > > > rt2x00usb_vendor_request_buff(rt2x00dev, USB_MULTI_READ, > > > USB_VENDOR_REQUEST_IN, offset, > > > ®, sizeof(reg)); > > > > Are you sure this is valid to call th

Re: [PATCH] rt2x00: reset reg earlier in rt2500usb_register_read

2021-01-21 Thread 慕冬亮
On Thu, Jan 21, 2021 at 5:49 PM Greg KH wrote: > > On Thu, Jan 21, 2021 at 05:20:26PM +0800, Dongliang Mu wrote: > > In the function rt2500usb_register_read(_lock), reg is uninitialized > > in some situation. Then KMSAN reports uninit-value at its first memory > > access. To fix this issue, add on

[PATCH] rt2x00: reset reg earlier in rt2500usb_register_read

2021-01-21 Thread Dongliang Mu
In the function rt2500usb_register_read(_lock), reg is uninitialized in some situation. Then KMSAN reports uninit-value at its first memory access. To fix this issue, initialize reg with zero in the function rt2500usb_register_read and rt2500usb_register_read_lock BUG: KMSAN: uninit-value in rt250

Re: [PATCH] rt2x00: reset reg earlier in rt2500usb_register_read

2021-01-21 Thread Greg KH
On Thu, Jan 21, 2021 at 05:20:26PM +0800, Dongliang Mu wrote: > In the function rt2500usb_register_read(_lock), reg is uninitialized > in some situation. Then KMSAN reports uninit-value at its first memory > access. To fix this issue, add one reg initialization in the function > rt2500usb_register_

[PATCH] rt2x00: reset reg earlier in rt2500usb_register_read

2021-01-21 Thread Dongliang Mu
In the function rt2500usb_register_read(_lock), reg is uninitialized in some situation. Then KMSAN reports uninit-value at its first memory access. To fix this issue, add one reg initialization in the function rt2500usb_register_read and rt2500usb_register_read_lock BUG: KMSAN: uninit-value in rt2