Re: [PATCH] r8169: Fix iteration variable sign

2006-11-30 Thread Francois Romieu
Jeff Garzik <[EMAIL PROTECTED]> : [...] > should this go into #upstream rather than #upstream-fixes? It's already in. The attribution does not follow the ordering of the Signed-off-by but the S-o-b are fine. -- Ueimor - To unsubscribe from this list: send the line "unsubscribe netdev" in the bo

Re: [PATCH] r8169: Fix iteration variable sign

2006-11-30 Thread Michael Buesch
On Thursday 30 November 2006 12:20, Jeff Garzik wrote: > Francois Romieu wrote: > > This changes the type of variable "i" in rtl8169_init_one() > > from "unsigned int" to "int". "i" is checked for < 0 later, > > which can never happen for "unsigned". This results in broken > > error handling. > >

Re: [PATCH] r8169: Fix iteration variable sign

2006-11-30 Thread Jeff Garzik
Francois Romieu wrote: This changes the type of variable "i" in rtl8169_init_one() from "unsigned int" to "int". "i" is checked for < 0 later, which can never happen for "unsigned". This results in broken error handling. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Signed-off-by: Franc

[PATCH] r8169: Fix iteration variable sign

2006-11-29 Thread Francois Romieu
This changes the type of variable "i" in rtl8169_init_one() from "unsigned int" to "int". "i" is checked for < 0 later, which can never happen for "unsigned". This results in broken error handling. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Signed-off-by: Francois Romieu <[EMAIL PROTECT

[PATCH] r8169: Fix iteration variable sign

2006-11-29 Thread Michael Buesch
This changes the type of variable "i" in rtl8169_init_one() from "unsigned int" to "int". "i" is checked for <0 later, which can never happen for "unsigned". This results in broken error handling. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Index: linux-2.6/drivers/net/r8169.c =