Re: [PATCH] r8152: Use guard clause and fix comment typos

2019-09-26 Thread David Miller
From: Prashant Malani Date: Mon, 23 Sep 2019 15:26:57 -0700 > Use a guard clause in tx_bottom() to reduce the indentation of the > do-while loop. In doing so, convert the do-while to a while to make the > guard clause checks consistent. > > Also, fix a couple of spelling and grammatical mistakes

Re: [PATCH] r8152: Use guard clause and fix comment typos

2019-09-24 Thread Grant Grundler
On Tue, Sep 24, 2019 at 4:47 PM Grant Grundler wrote: > > On Mon, Sep 23, 2019 at 7:47 PM Hayes Wang wrote: > > > > Prashant Malani [mailto:pmal...@chromium.org] > > > Sent: Tuesday, September 24, 2019 6:27 AM > > > To: Hayes Wang > > [...] > > > - do { > > > + while (1) { > > >

Re: [PATCH] r8152: Use guard clause and fix comment typos

2019-09-24 Thread Grant Grundler
On Mon, Sep 23, 2019 at 7:47 PM Hayes Wang wrote: > > Prashant Malani [mailto:pmal...@chromium.org] > > Sent: Tuesday, September 24, 2019 6:27 AM > > To: Hayes Wang > [...] > > - do { > > + while (1) { > > struct tx_agg *agg; > > + struct net_device *netdev = tp->

RE: [PATCH] r8152: Use guard clause and fix comment typos

2019-09-23 Thread Hayes Wang
Prashant Malani [mailto:pmal...@chromium.org] > Sent: Tuesday, September 24, 2019 6:27 AM > To: Hayes Wang [...] > - do { > + while (1) { > struct tx_agg *agg; > + struct net_device *netdev = tp->netdev; > > if (skb_queue_empty(&tp->tx_queue)) >

[PATCH] r8152: Use guard clause and fix comment typos

2019-09-23 Thread Prashant Malani
Use a guard clause in tx_bottom() to reduce the indentation of the do-while loop. In doing so, convert the do-while to a while to make the guard clause checks consistent. Also, fix a couple of spelling and grammatical mistakes in the r8152_csum_workaround() function comment. Change-Id: I460befde1