Re: [PATCH] pxa168: fix double deallocation of managed resources

2015-04-26 Thread David Miller
From: Alexey Khoroshilov Date: Sat, 25 Apr 2015 04:07:03 +0300 > Commit 43d3ddf87a57 ("net: pxa168_eth: add device tree support") starts > to use managed resources by adding devm_clk_get() and > devm_ioremap_resource(), but it leaves explicit iounmap() and clock_put() > in pxa168_eth_remove() and

[PATCH] pxa168: fix double deallocation of managed resources

2015-04-24 Thread Alexey Khoroshilov
Commit 43d3ddf87a57 ("net: pxa168_eth: add device tree support") starts to use managed resources by adding devm_clk_get() and devm_ioremap_resource(), but it leaves explicit iounmap() and clock_put() in pxa168_eth_remove() and in failure handling code of pxa168_eth_probe(). As a result double free