Re: [PATCH] ptp: ixp46x: remove NO_IRQ handling

2016-09-06 Thread Arnd Bergmann
On Tuesday, September 6, 2016 6:39:10 PM CEST Richard Cochran wrote: > On Tue, Sep 06, 2016 at 04:28:30PM +0200, Arnd Bergmann wrote: > > gpio_to_irq does not return NO_IRQ but instead returns a negative > > error code on failure. Returning NO_IRQ from the function has no > > negative effects as we

Re: [PATCH] ptp: ixp46x: remove NO_IRQ handling

2016-09-06 Thread Richard Cochran
On Tue, Sep 06, 2016 at 04:28:30PM +0200, Arnd Bergmann wrote: > gpio_to_irq does not return NO_IRQ but instead returns a negative > error code on failure. Returning NO_IRQ from the function has no > negative effects as we only compare the result to the expected > interrupt number, but it's better

[PATCH] ptp: ixp46x: remove NO_IRQ handling

2016-09-06 Thread Arnd Bergmann
gpio_to_irq does not return NO_IRQ but instead returns a negative error code on failure. Returning NO_IRQ from the function has no negative effects as we only compare the result to the expected interrupt number, but it's better to return a proper failure code for consistency, and we should remove N