Re: [PATCH] possible deadlock in tulip driver

2007-07-30 Thread Denis V. Lunev
Manual code check. The similar fixes are present in almost all drivers, f.e. tg3 one. I have an unrelated deadlock with rtnl. Regards, Den Valerie Henson wrote: (No longer maintainer, btw.) What situation have you tested this under? Thanks, -VAL On Tue, Jul 24, 2007 at 11:49:08AM +0400

Re: [PATCH] possible deadlock in tulip driver

2007-07-30 Thread Valerie Henson
(No longer maintainer, btw.) What situation have you tested this under? Thanks, -VAL On Tue, Jul 24, 2007 at 11:49:08AM +0400, Denis V. Lunev wrote: > Calling flush_scheduled_work() may deadlock if called under rtnl_lock > (from dev->stop) as linkwatch_event() may be on the workqueue and it wil

[PATCH] possible deadlock in tulip driver

2007-07-24 Thread Denis V. Lunev
Calling flush_scheduled_work() may deadlock if called under rtnl_lock (from dev->stop) as linkwatch_event() may be on the workqueue and it will try to get the rtnl_lock Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- tulip_core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)